-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Improve Error Message for Invalid Team Name Input #178
Comments
Mhh that used to work, we have a specifc error message for that which used to be shown if the team name didn't match the regex in the frontend. https://github.com/juice-shop/multi-juicer/blob/main/juice-balancer/ui/src/pages/JoinPage.js#L14 |
Sorry I overlooked your comment earlier. To me this is fine right now. I think having a different style for validation and for an actual error which was thrown for a valid input is totally fine. I'm closing this ticket now. Thank you all for the input and feedback here 🙌 |
Currently, when a user attempts to input an illegal team name, the system only displays a generic error message: Failed to create / join the team. This error message could be more descriptive and provide specific feedback on what went wrong with the suggested team name.
Here are some rules for valid team names that should be communicated in the error message (these are already available in the tooltip menu):
By providing a more detailed error message, we can guide the user to correct their input, thus enhancing the user experience.
The text was updated successfully, but these errors were encountered: