Skip to content

Commit c146b71

Browse files
fix: Update well known config value function response types (#376)
* Fix: Update well known config value function response types * Update CHANGELOG * Update wellknown typing array to be string[] * Update wellknown typing null can be default but would never be returned
1 parent 8ec206b commit c146b71

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1212
* Update construct typehint in docblock. #364
1313
* Fixed LogoutToken verification for single value aud claims #334
1414
* Added function to set useragent #370
15+
* Update well known config value function response types #376
1516

1617
### Added
1718
- Support for signed and encrypted UserInfo response. #305

src/OpenIDConnectClient.php

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -587,13 +587,13 @@ protected function addAdditionalJwk($jwk) {
587587
* Gets anything that we need configuration wise including endpoints, and other values
588588
*
589589
* @param string $param
590-
* @param string|array|null $default optional
591-
* @return string|array
590+
* @param string|string[]|bool|null $default optional
591+
* @return string|string[]|bool
592592
*
593-
*@throws OpenIDConnectClientException
593+
* @throws OpenIDConnectClientException
594594
*/
595-
protected function getProviderConfigValue(string $param, $default = null) {
596-
595+
protected function getProviderConfigValue(string $param, $default = null)
596+
{
597597
// If the configuration value is not available, attempt to fetch it from a well known config endpoint
598598
// This is also known as auto "discovery"
599599
if (!isset($this->providerConfig[$param])) {
@@ -607,12 +607,12 @@ protected function getProviderConfigValue(string $param, $default = null) {
607607
* Gets anything that we need configuration wise including endpoints, and other values
608608
*
609609
* @param string $param
610-
* @param string|null $default optional
611-
* @return string
610+
* @param string|string[]|bool|null $default optional
611+
* @return string|string[]|bool
612612
*
613-
*@throws OpenIDConnectClientException
613+
* @throws OpenIDConnectClientException
614614
*/
615-
protected function getWellKnownConfigValue(string $param, string $default = null): string
615+
protected function getWellKnownConfigValue(string $param, $default = null)
616616
{
617617

618618
// If the configuration value is not available, attempt to fetch it from a well known config endpoint

0 commit comments

Comments
 (0)