Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Jupyter Releaser #1188

Open
blink1073 opened this issue Nov 5, 2022 · 7 comments
Open

Use Jupyter Releaser #1188

blink1073 opened this issue Nov 5, 2022 · 7 comments
Assignees

Comments

@blink1073
Copy link
Contributor

@kevin-bates mentioned that we'd like to use Jupyter Releaser in this repo.

I think we need the following:

  • Have a script that handles version bumps with a single argument for the new version. It should probably be a python script that combines what update_version_to_release and update_version_to_development do and "does the right thing" based on whether the version has dev in it.

  • Add an after-build-python releaser hook with ["make kernelspecs helm-chart docker-images"]

  • Add a step in the publish workflow that runs publish-images with shared credentials so it isn't run in check-release.
    We can add a bot docker account for these credentials.

@kevin-bates
Copy link
Member

Thank you @blink1073. I'd like to spend some time on this early next week. Can you recommend a good "model project" from which I can copy the basics? I don't think jupyter_server is ideal due to its dependency on npm and wondering if something like jupyter_client or nbclient might be better.

I would also like to generate the first release of remote_provisioners next week and would love to have releaser support there, but wondering if releaser is something that can be used outside the organization?

@blink1073
Copy link
Contributor Author

nbconvert is a reasonable example.

jupyter_server has a good example of using hooks.

jupyterlab has an example of using a custom version-cmd

@kevin-bates
Copy link
Member

I'm not sure when we can get to this but will definitely refer to these when we do - thanks!

@blink1073
Copy link
Contributor Author

The version bump script could be done independently - and used from release.sh.

@rahul26goyal
Copy link
Contributor

Hi @blink1073
I can work with you on this with guidance. Let me go over the examples which you have shared this weekend and get back to you early next week?

@blink1073
Copy link
Contributor Author

Sounds good, thanks @rahul26goyal!

@kevin-bates
Copy link
Member

Hi @rahul26goyal - when you get to this, it would be good to reduce the release preparation and post-release commits to one each, instead of two, as it is now. I suspect this is a side-effect of using tbump within release.sh and it may not be possible to reduce down to a single commit for each phase, but I think it would be good to understand if that's possible. Thanks.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants