Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pre-fetching of css files? #2093

Closed
AlexanderRichert-NOAA opened this issue Jan 9, 2024 · 2 comments · Fixed by #2095
Closed

Allow pre-fetching of css files? #2093

AlexanderRichert-NOAA opened this issue Jan 9, 2024 · 2 comments · Fixed by #2095

Comments

@AlexanderRichert-NOAA
Copy link
Contributor

As far as I can tell, nbconvert cannot be built on non-internet connected systems, such as in an automated build system on an airgapped node. In hatch_build.py, it tries to download each css file (on at least one system I'm working on, the urlopen(url).read() function hangs indefinitely) before checking for an existing copy. Would it be possible to check for the destination file before trying to download it? In my use case (installing through Spack), it's fine to stage the files in advance so they're available at install time.

@blink1073
Copy link
Contributor

Hi @AlexanderRichert-NOAA, that sounds reasonable, would you be able to submit a PR?

@AlexanderRichert-NOAA
Copy link
Contributor Author

@blink1073 yes, please see #2095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants