Skip to content

Commit 5efd26a

Browse files
committed
ci: update job name to include install constraints (test old versions)
1 parent 2d9d226 commit 5efd26a

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

.github/workflows/test.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
path: ./dist
6363

6464
test:
65-
name: ${{ matrix.os }} ${{ matrix.python-version }} ${{ matrix.pip-extras }}
65+
name: ${{ matrix.os }} ${{ matrix.python-version }} ${{ matrix.pip-extras }} ${{ matrix.pip-install-constraints }}
6666
needs: [build]
6767
timeout-minutes: 30
6868
runs-on: ${{ matrix.os }}
@@ -99,11 +99,16 @@ jobs:
9999
- os: ubuntu-22.04
100100
python-version: "3.8"
101101
pip-extras: classic
102+
# jupyter-client and jupyter-core are transient dependencies for
103+
# jupyter-server that we have to pin to avoid issues installing
104+
# tornado as old as 5.1
102105
pip-install-constraints: >-
103106
jupyter-server==1.0
104107
simpervisor==1.0
105108
tornado==5.1
106109
traitlets==4.2.1
110+
jupyter-client==7.2.0
111+
jupyter-core==4.9.2
107112
108113
# Workaround for excluded 3.12 test mentioned in a FIXME above
109114
- os: ubuntu-22.04

0 commit comments

Comments
 (0)