Skip to content

Commit a06b49e

Browse files
committed
Verify support for Python 3.12
1 parent fff7d4f commit a06b49e

File tree

5 files changed

+20
-12
lines changed

5 files changed

+20
-12
lines changed

.github/workflows/linkcheck.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
- uses: actions/checkout@v4
2525
- uses: actions/setup-python@v5
2626
with:
27-
python-version: "3.11"
27+
python-version: "3.12"
2828

2929
- name: Install deps
3030
run: pip install -r docs/requirements.txt

.github/workflows/publish.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636

3737
- uses: actions/setup-python@v5
3838
with:
39-
python-version: "3.11"
39+
python-version: "3.12"
4040

4141
- uses: actions/setup-node@v4
4242
with:
@@ -90,7 +90,7 @@ jobs:
9090
steps:
9191
- uses: actions/setup-python@v5
9292
with:
93-
python-version: "3.11"
93+
python-version: "3.12"
9494

9595
- name: Download artifacts from build
9696
uses: actions/download-artifact@v4

.github/workflows/test.yaml

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040

4141
- uses: actions/setup-python@v5
4242
with:
43-
python-version: "3.11"
43+
python-version: "3.12"
4444

4545
- uses: actions/setup-node@v4
4646
with:
@@ -74,19 +74,26 @@ jobs:
7474
fail-fast: false
7575
matrix:
7676
os: [ubuntu-22.04, windows-2022]
77-
python-version: ["3.8", "3.11"]
78-
pip-extras: ["lab", "classic"]
77+
python-version: ["3.8", "3.12"]
78+
pip-extras: [lab, classic]
7979
pip-install-constraints: [""]
8080
exclude:
8181
# windows should work for all test variations, but a limited selection
8282
# is run to avoid doubling the amount of test runs
8383
- os: windows-2022
84-
python-version: "3.11"
84+
python-version: "3.12"
8585
pip-extras: classic
8686
- os: windows-2022
8787
python-version: "3.8"
8888
pip-extras: lab
8989

90+
# FIXME: If https://github.com/jupyter/notebook/pull/7305 gets merged
91+
# and released, we can test "classic" with python 3.12 as well,
92+
# but until then we exclude it from being run as a Python 3.12
93+
# test and include it as a Python 3.11 test.
94+
- os: ubuntu-22.04
95+
python-version: "3.12"
96+
pip-extras: classic
9097
include:
9198
# this test is manually updated to reflect the lower bounds of
9299
# versions from dependencies
@@ -99,6 +106,11 @@ jobs:
99106
tornado==6.1.0
100107
traitlets==5.1.0
101108
109+
# Workaround for excluded 3.12 test mentioned in a FIXME above
110+
- os: ubuntu-22.04
111+
python-version: "3.11"
112+
pip-extras: classic
113+
102114
steps:
103115
- uses: actions/checkout@v4
104116

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ For example, after installing [`mambaforge`](https://conda-forge.org/miniforge),
2525
create a new environment with all heavy development and test dependencies:
2626

2727
```yaml
28-
mamba create --name=jupyter-server-proxy --channel=conda-forge "python=3.11" "nodejs=20" pip git geckodriver firefox
28+
mamba create --name=jupyter-server-proxy --channel=conda-forge "python=3.12" "nodejs=20" pip git geckodriver firefox
2929
mamba activate jupyter-server-proxy
3030
```
3131

pyproject.toml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,6 @@ classifiers = [
4040
"Operating System :: POSIX :: Linux",
4141
"Programming Language :: Python",
4242
"Programming Language :: Python :: 3",
43-
"Programming Language :: Python :: 3.8",
44-
"Programming Language :: Python :: 3.9",
45-
"Programming Language :: Python :: 3.10",
46-
"Programming Language :: Python :: 3.11",
4743
]
4844
dependencies = [
4945
"aiohttp",

0 commit comments

Comments
 (0)