Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook tours, icons #29

Merged
merged 12 commits into from
Nov 5, 2023

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented May 22, 2021

  • fixes JSON Tours in Notebook metadata #26 (at least the show-a-tour part)
  • includes Fix id in TourManager.addTour #28
  • adds some icons
  • unifies translation and sorting in the tourManager
  • use schema to validate metadata
  • figure out how to un-confuse ts-jest when using the tsconfig.json setup that allows for importing schema, etc.
  • update some more things to be IOptions instead of ever-longer positional/optional args?
  • add a label to the launch args to be able to find by human-readable name?
    • this would allow for command-linker HTML, which would be nice

  • improve/replace the launch dialog
    • at a minimum, show the human-readable name
  • add tours to launcher?
  • add some client specificity awareness to tours
    • notebookPage?
  • create a MIME renderer?
  • avoid extra copy of ajv
  • avoid duplicate assets in $prefix/share and labextension
  • toast?

screens

what it looks like
basic notebook ui Screenshot from 2021-05-22 14-50-58
icons in help Screenshot from 2021-05-22 14-51-11
icon in palette Screenshot from 2021-05-22 14-51-55
icon in advanced settings Screenshot from 2021-05-22 14-53-55
icon when it's busted Screenshot from 2021-05-22 16-59-14

@fcollonval
Copy link
Member

@bollwyvl would you have time to look at the rebase?

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Sep 13, 2023 via email

@fcollonval
Copy link
Member

Yeah, meant to do that, but frankly don't remember what was contentious/half done, so might take me a bit of looking.

Thanks for getting back. Don't worry then. I'll move forward with this to get closer to a release; there are still two points I want to address before that.

@bollwyvl
Copy link
Contributor Author

Looking now... i see you already did the rebase. Rad! Looking now.

@bollwyvl
Copy link
Contributor Author

Ran the setup locally and made some changes to the template-generated stuff which burned my eyes.

I'll update the top comment with some thoughts on possible tasks to get this out the door...

@bollwyvl
Copy link
Contributor Author

Looking at the list of stuff i added up top, it is again probably not worth blocking on this to get a major version alpha out that works with lab4/nb7, though some of the API changes would be breaking.

Probably want a 3.x branch (from ... a fairly long time ago), so we at least have the option of backporting stuff, time/need permitting.

@fcollonval fcollonval merged commit 02261db into jupyterlab-contrib:main Nov 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Tours in Notebook metadata
2 participants