Fix shell pollution by third party extension (#21)

* Fix shell pollution by third party extension * Real fix
jupyterlab-contrib · Feb 26, 2023 · 3b08262 · 3b08262
1 parent 7b3146a
commit 3b08262
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/application/src/app/index.ts b/packages/application/src/app/index.ts
@@ -15,7 +15,7 @@ import { BoxLayout, Widget } from '@lumino/widgets';
 /**
  * The Rise application shell token.
  */
-export const IRetroShell = new Token<RiseShell>(
+export const IRiseShell = new Token<RiseShell>(
   'jupyterlab-rise-application:IRiseShell'
 );
 
@@ -60,8 +60,9 @@ export class RiseShell extends Widget implements JupyterFrontEnd.IShell {
     area?: string,
     options?: DocumentRegistry.IOpenOptions
   ): void {
-    if ((this.layout as BoxLayout).widgets.length > 0) {
-      // pass no-op
+    if ((this.layout as BoxLayout).widgets.length > 0 || area !== 'rise') {
+      // Bail
+      return;
     }
     BoxLayout.setStretch(widget, 1);
     (this.layout as BoxLayout).addWidget(widget);

diff --git a/packages/application/src/plugins/rise.ts b/packages/application/src/plugins/rise.ts
@@ -146,7 +146,7 @@ export const plugin: JupyterFrontEndPlugin<void> = {
       // notebookPanel.toolbar.dispose();
       notebookPanel.toolbar.hide();
 
-      app.shell.add(notebookPanel);
+      app.shell.add(notebookPanel, 'rise');
     });
   }
 };