Remove stylecope

Author: jviau

.editorconfig

@@ -10,9 +10,11 @@ indent_style = space
 
 # Code files
 [*.{cs,csx,vb,vbx}]
+file_header_template = "Copyright (c) Jacob Viau. All rights reserved.\nLicensed under the Apache License 2.0. See LICENSE file in the project root for full license information."
 indent_size = 4
 insert_final_newline = true
 charset = utf-8-bom
+trim_trailing_whitespace = true
 
 [*.xaml]
 indent_size = 4
@@ -123,6 +125,9 @@ dotnet_naming_style.pascal_case_and_prefix_with_I_style.capitalization
 # CSharp code style settings:
 [*.cs]
 
+# Modifier preferences
+csharp_preferred_modifier_order = public,private,protected,internal,file,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,required,volatile,async:warning
+
 # Prefer "var" only when the type is apparent
 csharp_style_var_for_built_in_types = false:suggestion
 csharp_style_var_when_type_is_apparent = true:suggestion
@@ -157,6 +162,9 @@ dotnet_style_prefer_conditional_expression_over_return = false
 dotnet_style_prefer_conditional_expression_over_assignment = false
 dotnet_style_prefer_auto_properties = false
 
+# 'using' directive preferences
+csharp_using_directive_placement = outside_namespace:warning
+
 # Newline settings
 csharp_new_line_before_open_brace = all
 csharp_new_line_before_else = true
@@ -170,7 +178,7 @@ csharp_new_line_between_query_expression_clauses = true
 csharp_indent_case_contents = true
 csharp_indent_case_contents_when_block = false
 csharp_indent_switch_labels = true
-csharp_indent_labels = no_change
+csharp_indent_labels = one_less_than_current
 csharp_indent_block_contents = true
 csharp_indent_braces = false
 
@@ -242,15 +250,6 @@ dotnet_diagnostic.CA2007.severity = none # Consider calling ConfigureAwait on th
 dotnet_diagnostic.CA2326.severity = none # Do not use TypeNameHandling values other than None
 dotnet_diagnostic.CA2327.severity = none # Do not use insecure JsonSerializerSettings
 
-# StyleCop rules
-dotnet_diagnostic.SA1101.severity = none  # Prefix local calls with this
-dotnet_diagnostic.SA1308.severity = none  # Variable names should not be prefixed
-dotnet_diagnostic.SA1309.severity = none  # Field names should not begin with underscore
-dotnet_diagnostic.SA1311.severity = none  # Static readonly fields should begin with upper-case letter
-dotnet_diagnostic.SX1101.severity = error # Do not prefix local calls with 'this.'
-dotnet_diagnostic.SX1309.severity = error # Field names should begin with underscore
-dotnet_diagnostic.SX1309S.severity = none # Static field names should begin with underscore
-
 [**/*Tests/**/*.cs]
 # We allow usage of "var" inside tests as it reduces churn as we remove/rename types
 csharp_style_var_for_built_in_types = true:none

Directory.Packages.props

@@ -35,10 +35,6 @@
     <PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="6.0.0" />
   </ItemGroup>
 
-  <!-- Nuget -->
-  <ItemGroup>
-  </ItemGroup>
-
    <!-- Test projects -->
   <ItemGroup>
     <PackageVersion Include="Bogus" Version="27.0.1" />
@@ -57,9 +53,6 @@
   <!-- Global -->
   <ItemGroup>
     <GlobalPackageReference Include="Nerdbank.GitVersioning" Version="3.6.133" Condition="'$(EnableGitVersioning)' != 'false'" />
-    <GlobalPackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.406" Condition="'$(EnableStyleCop)' != 'false'" />
-    <GlobalPackageReference Include="StyleCop.CSharp.Async.Rules" Version="6.1.41" Condition="'$(EnableStyleCop)' != 'false'" />
-    <GlobalPackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" Condition="'$(IsPackable)' != 'false'" />
   </ItemGroup>
 
 </Project>

src/DurableTask.Hosting.sln

@@ -1,7 +1,7 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio Version 16
-VisualStudioVersion = 16.0.29911.98
+# Visual Studio Version 17
+VisualStudioVersion = 17.12.35506.116 d17.12
 MinimumVisualStudioVersion = 15.0.26124.0
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "DurableTask.DependencyInjection", "DurableTask.DependencyInjection", "{F7C54D09-8F90-40A6-A7ED-DBF11FD97354}"
 EndProject
@@ -220,8 +220,10 @@ Global
 		{971A0F3F-135E-4F8A-AAE0-9D1EDE7CA6B6} = {27F8590A-1B83-49D9-A5B9-E7CF7E106FE6}
 		{0BF2E951-4F1F-46DC-9518-20565E3FD11A} = {428F76B3-2E22-43A4-ADBE-273B42492BE3}
 		{09A0BB2C-379F-4F62-AE98-955978CA5A66} = {428F76B3-2E22-43A4-ADBE-273B42492BE3}
+		{13175B27-AEBC-4535-8B0F-E2A6A7E98E96} = {796C6FFF-5FB6-4918-88B7-61B6EA4D2801}
 		{052B06E1-0268-446A-BA1A-57B8A8AD8B22} = {2CEE0150-2FD3-4246-82DA-2EB68A95FCF3}
 		{E1AD91B6-6458-4502-9AC1-0FFE93D2FBE6} = {2CEE0150-2FD3-4246-82DA-2EB68A95FCF3}
+		{A51D0C94-E0B9-4063-A8C9-7424362CDB80} = {796C6FFF-5FB6-4918-88B7-61B6EA4D2801}
 	EndGlobalSection
 	GlobalSection(ExtensibilityGlobals) = postSolution
 		SolutionGuid = {65A5E590-4609-44E1-B012-0EA997E18DB7}