Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACK every N frames #28

Open
jwbensley opened this issue Sep 16, 2017 · 1 comment
Open

ACK every N frames #28

jwbensley opened this issue Sep 16, 2017 · 1 comment

Comments

@jwbensley
Copy link
Owner

Add a CLI option to ACK one in every N frames, otherwise ACK mode is very slow on a stable link with no drops.

@jwbensley
Copy link
Owner Author

Reported by @yskripachov

diff --git a/functions.c b/functions.c                                                                           
index a36ece5..faad4f4 100644                                                                                    
--- a/functions.c                                                                                                
+++ b/functions.c                                                                                                
@@ -2214,7 +2214,7 @@ void sync_settings(struct app_params *app_params,                                          
                 // TX has set ACK mode frame count                                                              
                 } else if (ntohs(*frame_headers->rx_sub_tlv_type) == TYPE_ACKCOUNT) {                           
                                                                                                                 
-                    test_params->f_ack_timeout = (uint32_t)ntohll(*frame_headers->rx_sub_tlv_value);            
+                    test_params->f_ack_count = (uint32_t)ntohll(*frame_headers->rx_sub_tlv_value);              
                     printf("ACK mode set to ACK every %" PRIu32 " frames\n", test_params->f_ack_count);         
                                                                                                                 
                 // TX has requested MTU sweep test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant