Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove login dialogs from browser history #191

Open
dbudzins opened this issue Nov 16, 2022 · 0 comments
Open

Remove login dialogs from browser history #191

dbudzins opened this issue Nov 16, 2022 · 0 comments

Comments

@dbudzins
Copy link
Contributor

dbudzins commented Nov 16, 2022

Right now the sign in and sign up prompts have their own URLs. This is fine, but the URL's should get removed from the browser history when they close so that using the back button doesn't reopen them.

Repro 1:

  • Login
  • Use the back button and observe that the login prompt is shown again
    Expectations: The back button should go to whatever the screen prior to the login attempt was.

Repro 2

  • Click login
  • Click Cancel
  • Use the back button and observe that the login prompt is displayed again
    Expectations: The back button should go to whatever the screen prior to opening the login prompt was

Probably just using replace instead of navigate will fix this. Please triage all dialogs and decide whether they make sense as part of the history or not.

@dbudzins dbudzins changed the title Remove cancelled login prompts from back button Remove login dialogs from browser history Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant