New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service modularization todos #399

Open

3 of 6 tasks

ChristiaanScheermeijer opened this issue Nov 14, 2023 · 1 comment

Labels

enhancement technical-debt

Collaborator

ChristiaanScheermeijer commented Nov 14, 2023 •

edited

Loading

I've collected some TODOs from the service modularization PR #363 so we don't forget.

@AntonLantukh @dbudzins Feel free to add or remove items from the lists.

TODOs:

Move integration service files into folders e.g., ./src/services/integrations/jwp/InPlayerAccountService.ts
Refactor entitlement service(s) to align with the integration better
Refactor isSandbox from all service calls (not sure about this yet)
Obtain the access model via integration (by optionally passing the media item?)

Minor TODOs (long term):

Make integration interfaces more generic for different implementations (currently following Cleeng schemas and APIs)
Dynamically load and bind integration files in IoC based on directory structure

The text was updated successfully, but these errors were encountered:

ChristiaanScheermeijer added enhancement technical-debt labels

Collaborator Author

ChristiaanScheermeijer commented Feb 8, 2024

Some TODOs are solved in #450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment