Skip to content

Commit af5ed77

Browse files
committed
Improve dead lock servlet 2
1 parent df4e228 commit af5ed77

File tree

3 files changed

+11
-17
lines changed

3 files changed

+11
-17
lines changed

pom.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
<dependency>
6161
<groupId>mysql</groupId>
6262
<artifactId>mysql-connector-java</artifactId>
63-
<version>5.1.17</version>
63+
<version>5.1.25</version>
6464
</dependency>
6565
<dependency>
6666
<groupId>org.slf4j</groupId>
@@ -169,15 +169,15 @@
169169
<artifactId>exec-maven-plugin</artifactId>
170170
<version>1.2</version>
171171
<!-- Comment out Payara sections to avoid proxy error due to slow downloading. -->
172-
<!-- <dependencies>
172+
<dependencies>
173173
<dependency>
174174
<groupId>fish.payara.extras</groupId>
175175
<artifactId>payara-micro</artifactId>
176176
<version>4.1.1.162</version>
177177
</dependency>
178-
</dependencies> -->
178+
</dependencies>
179179
<executions>
180-
<!-- <execution>
180+
<execution>
181181
<id>payara-uber-jar</id>
182182
<phase>package</phase>
183183
<goals>
@@ -201,7 +201,7 @@
201201
<artifactId>payara-micro</artifactId>
202202
</executableDependency>
203203
</configuration>
204-
</execution> -->
204+
</execution>
205205
<execution>
206206
<id>startup-embedded-jetty</id>
207207
<phase>install</phase>

src/main/java/org/t246osslab/easybuggy/troubles/DeadlockServlet2.java

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -156,18 +156,16 @@ private String updateUsers(ArrayList<User> users, Locale locale) {
156156
int executeUpdate = 0;
157157
String resultMessage = "";
158158
try {
159-
160159
conn = DBClient.getConnection();
161160
conn.setAutoCommit(false);
162-
// conn.setTransactionIsolation(Connection.TRANSACTION_READ_COMMITTED);
163-
164161
stmt = conn.prepareStatement("Update users set name = ?, phone = ?, mail = ? where id = ?");
165162
for (User user : users) {
166163
stmt.setString(1, user.getName());
167164
stmt.setString(2, user.getPhone());
168165
stmt.setString(3, user.getMail());
169166
stmt.setString(4, user.getUserId());
170167
executeUpdate = executeUpdate + stmt.executeUpdate();
168+
log.info(user.getUserId() +" is updated.");
171169
Thread.sleep(500);
172170
}
173171
conn.commit();
@@ -179,12 +177,8 @@ private String updateUsers(ArrayList<User> users, Locale locale) {
179177
log.error("SQLTransactionRollbackException occurs: ", e);
180178
rollbak(conn);
181179
} catch (SQLException e) {
182-
if ("41000".equals(e.getSQLState())) {
183-
resultMessage = MessageUtils.getErrMsg("msg.deadlock.occurs", locale);
184-
} else {
185-
resultMessage = MessageUtils.getErrMsg("msg.unknown.exception.occur", new String[] { e.getMessage() },
186-
locale);
187-
}
180+
resultMessage = MessageUtils.getErrMsg("msg.unknown.exception.occur", new String[] { e.getMessage() },
181+
locale);
188182
log.error("SQLException occurs: ", e);
189183
rollbak(conn);
190184
} catch (Exception e) {

src/main/resources/log4j.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<appender name="STDOUT" class="org.apache.log4j.ConsoleAppender">
77
<param name="Target" value="System.out" />
88
<layout class="org.apache.log4j.PatternLayout">
9-
<param name="ConversionPattern" value="%d{yyyy-MM-dd HH:mm:ss} %5p %c{1} %m%n" />
9+
<param name="ConversionPattern" value="%d{yyyy-MM-dd HH:mm:ss} %5p %t %c{1} %m%n" />
1010
</layout>
1111
</appender>
1212

@@ -16,12 +16,12 @@
1616
<param name="MaxFileSize" value="5MB" />
1717
<param name="MaxBackupIndex" value="5" />
1818
<layout class="org.apache.log4j.PatternLayout">
19-
<param name="ConversionPattern" value="%d{yyyy-MM-dd HH:mm:ss} %5p %c{1} %m%n" />
19+
<param name="ConversionPattern" value="%d{yyyy-MM-dd HH:mm:ss} %5p %t %c{1} %m%n" />
2020
</layout>
2121
</appender>
2222

2323
<root>
24-
<priority value ="ERROR" />
24+
<priority value ="INFO" />
2525
<appender-ref ref="STDOUT"/>
2626
<appender-ref ref="FILE"/>
2727
</root>

0 commit comments

Comments
 (0)