Skip to content

Commit 3e59986

Browse files
committed
Replace image-bundler with k0s airgap bundle-artifacts
Dog-food the new sub-command in the k0s build itself. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
1 parent 9568fa3 commit 3e59986

File tree

5 files changed

+10
-56
lines changed

5 files changed

+10
-56
lines changed

.github/workflows/build-airgap-image-bundle.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,11 @@ jobs:
3333
with:
3434
persist-credentials: false
3535

36+
- name: "Download :: k0s"
37+
uses: actions/download-artifact@v4
38+
with:
39+
name: k0s-linux-amd64
40+
3641
- name: "Download :: Airgap image list"
3742
uses: actions/download-artifact@v4
3843
with:
@@ -44,7 +49,7 @@ jobs:
4449
- name: "Cache :: Airgap image bundle :: Calculate cache key"
4550
id: cache-airgap-image-bundle-calc-key
4651
env:
47-
HASH_VALUE: ${{ hashFiles('Makefile', 'airgap-images.txt', 'hack/image-bundler/*') }}
52+
HASH_VALUE: ${{ hashFiles('Makefile', 'airgap-images.txt', 'cmd/airgap/*', 'pkg/airgap/*') }}
4853
run: |
4954
printf 'cache-key=build-airgap-image-bundle-%s-%s-%s\n' "$TARGET_OS" "$TARGET_ARCH" "$HASH_VALUE" >> "$GITHUB_OUTPUT"
5055
@@ -58,6 +63,7 @@ jobs:
5863
- name: "Build :: Airgap image bundle"
5964
if: steps.cache-airgap-image-bundle.outputs.cache-hit != 'true'
6065
run: |
66+
chmod +x k0s
6167
mkdir -p "embedded-bins/staging/$TARGET_OS/bin"
6268
make --touch airgap-images.txt
6369
make "airgap-image-bundle-$TARGET_OS-$TARGET_ARCH.tar"

.github/workflows/go.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ jobs:
309309
id: cache-airgap-image-bundle
310310
uses: actions/cache@v4
311311
with:
312-
key: airgap-image-bundle-linux-${{ matrix.arch }}-${{ hashFiles('Makefile', 'airgap-images.txt', 'hack/image-bundler/*') }}
312+
key: airgap-image-bundle-linux-${{ matrix.arch }}-${{ hashFiles('Makefile', 'airgap-images.txt', 'cmd/airgap/*', 'pkg/airgap/*') }}
313313
path: |
314314
airgap-images.txt
315315
airgap-image-bundle-linux-${{ matrix.arch }}.tar

Makefile

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -241,15 +241,8 @@ airgap-image-bundle-linux-arm64.tar: TARGET_PLATFORM := linux/arm64
241241
airgap-image-bundle-linux-arm.tar: TARGET_PLATFORM := linux/arm/v7
242242
airgap-image-bundle-linux-amd64.tar \
243243
airgap-image-bundle-linux-arm64.tar \
244-
airgap-image-bundle-linux-arm.tar: .k0sbuild.image-bundler.stamp airgap-images.txt
245-
$(DOCKER) run --rm -i --privileged \
246-
-e TARGET_PLATFORM='$(TARGET_PLATFORM)' \
247-
'$(shell cat .k0sbuild.image-bundler.stamp)' < airgap-images.txt > '$@'
248-
249-
.k0sbuild.image-bundler.stamp: hack/image-bundler/* embedded-bins/Makefile.variables
250-
$(DOCKER) build --progress=plain --iidfile '$@' \
251-
--build-arg ALPINE_VERSION=$(alpine_patch_version) \
252-
-t k0sbuild.image-bundler -- hack/image-bundler
244+
airgap-image-bundle-linux-arm.tar: k0s airgap-images.txt
245+
./k0s airgap -v bundle-artifacts --platform='$(TARGET_PLATFORM)' -o '$@' <airgap-images.txt
253246

254247
.PHONY: $(smoketests)
255248
check-airgap check-ap-airgap: airgap-image-bundle-linux-$(HOST_ARCH).tar
@@ -280,9 +273,7 @@ clean-docker-image:
280273
$(clean-iid-files)
281274

282275
.PHONY: clean-airgap-image-bundles
283-
clean-airgap-image-bundles: IID_FILES = .k0sbuild.image-bundler.stamp
284276
clean-airgap-image-bundles:
285-
$(clean-iid-files)
286277
-rm airgap-images.txt
287278
-rm airgap-image-bundle-linux-amd64.tar airgap-image-bundle-linux-arm64.tar airgap-image-bundle-linux-arm.tar
288279

hack/image-bundler/Dockerfile

Lines changed: 0 additions & 6 deletions
This file was deleted.

hack/image-bundler/bundler.sh

Lines changed: 0 additions & 37 deletions
This file was deleted.

0 commit comments

Comments
 (0)