Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release for android C API #1634

Closed
thewh1teagle opened this issue Dec 20, 2024 · 4 comments · Fixed by #1635
Closed

Add release for android C API #1634

thewh1teagle opened this issue Dec 20, 2024 · 4 comments · Fixed by #1635

Comments

@thewh1teagle
Copy link
Contributor

It will be useful if sherpa-onnx release aarch64-linux-android and armv7-linux-androideabi C API libraries to releases.
I think that it should built with NDK

Related: thewh1teagle/sherpa-rs#29

@thewh1teagle
Copy link
Contributor Author

thewh1teagle commented Dec 20, 2024

I guess I can use the .so files from https://github.com/k2-fsa/sherpa-onnx/releases/download/v1.10.35/sherpa-onnx-v1.10.35-android.tar.bz2 but there's no headers so I'll need to fetch it from the source

Update: I can't. It's only jni so files.

@csukuangfj
Copy link
Collaborator

Please turn on the option.in the build shell script to build C API.

@thewh1teagle
Copy link
Contributor Author

thewh1teagle commented Dec 20, 2024

Please turn on the option.in the build shell script to build C API.

Could you also share the URL of the file?

Would it be possible to add this release by default to sherpa-onnx, or is there a specific reason not to?

@csukuangfj
Copy link
Collaborator

Could you change

./build-android-arm64-v8a.sh

to

            export SHERPA_ONNX_ENABLE_C_API=ON
           ./build-android-arm64-v8a.sh 

Also, similarly, could you change

./build-android-armv7-eabi.sh

./build-android-x86-64.sh

./build-android-x86.sh

Then the next release will contain C API .so for Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants