Skip to content

Commit eed77ae

Browse files
samrocketmanAlexsJones
samrocketman
and
AlexsJones
authored
go fmt sinks_test and slack (#378)
This kept showing up in my other pull request as an issue. I kept discarding it in that PR but here's one to fix it for good. I ran ``` go fmt ./... ``` Signed-off-by: Sam Gleske <sam.mxracer@gmail.com> Co-authored-by: Alex Jones <alexsimonjones@gmail.com>
1 parent 8b0a4bb commit eed77ae

File tree

2 files changed

+112
-113
lines changed

2 files changed

+112
-113
lines changed

‎pkg/sinks/sinks_test.go

Lines changed: 112 additions & 112 deletions
Original file line numberDiff line numberDiff line change
@@ -72,121 +72,121 @@ func Test_MattermostSinkConfigure(t *testing.T) {
7272
}
7373

7474
func Test_MattermostSinkEmit(t *testing.T) {
75-
tests := []struct {
76-
name string
77-
results v1alpha1.ResultSpec
78-
responseCode int
79-
expectError bool
80-
}{
81-
{
82-
name: "Error details with successful response",
83-
results: v1alpha1.ResultSpec{
84-
Error: []v1alpha1.Failure{
85-
{Text: "First error"},
86-
{Text: "Second error"},
87-
},
88-
},
89-
responseCode: http.StatusOK,
90-
expectError: false,
91-
},
92-
{
93-
name: "Non-empty details with failed response",
94-
results: v1alpha1.ResultSpec{
95-
Details: "Some details",
96-
},
97-
responseCode: http.StatusInternalServerError,
98-
expectError: true,
99-
},
100-
}
101-
102-
for _, tt := range tests {
103-
t.Run(tt.name, func(t *testing.T) {
104-
sink := &MattermostSink{
105-
Endpoint: "",
106-
Client: *NewClient(2 * time.Second),
107-
}
108-
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
109-
w.WriteHeader(tt.responseCode)
110-
}))
111-
defer server.Close()
112-
113-
sink.Endpoint = server.URL
114-
115-
err := sink.Emit(tt.results)
116-
117-
if tt.expectError {
118-
assert.Error(t, err)
119-
} else {
120-
assert.NoError(t, err)
121-
}
122-
})
123-
}
75+
tests := []struct {
76+
name string
77+
results v1alpha1.ResultSpec
78+
responseCode int
79+
expectError bool
80+
}{
81+
{
82+
name: "Error details with successful response",
83+
results: v1alpha1.ResultSpec{
84+
Error: []v1alpha1.Failure{
85+
{Text: "First error"},
86+
{Text: "Second error"},
87+
},
88+
},
89+
responseCode: http.StatusOK,
90+
expectError: false,
91+
},
92+
{
93+
name: "Non-empty details with failed response",
94+
results: v1alpha1.ResultSpec{
95+
Details: "Some details",
96+
},
97+
responseCode: http.StatusInternalServerError,
98+
expectError: true,
99+
},
100+
}
101+
102+
for _, tt := range tests {
103+
t.Run(tt.name, func(t *testing.T) {
104+
sink := &MattermostSink{
105+
Endpoint: "",
106+
Client: *NewClient(2 * time.Second),
107+
}
108+
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
109+
w.WriteHeader(tt.responseCode)
110+
}))
111+
defer server.Close()
112+
113+
sink.Endpoint = server.URL
114+
115+
err := sink.Emit(tt.results)
116+
117+
if tt.expectError {
118+
assert.Error(t, err)
119+
} else {
120+
assert.NoError(t, err)
121+
}
122+
})
123+
}
124124
}
125125

126126
func Test_SlackSinkConfigure(t *testing.T) {
127-
sink := &SlackSink{}
128-
client := NewClient(2 * time.Second)
129-
config := v1alpha1.K8sGPT{
130-
Spec: v1alpha1.K8sGPTSpec{
131-
Sink: &v1alpha1.WebhookRef{
132-
Endpoint: "http://example.com",
133-
},
134-
},
135-
}
136-
137-
sink.Configure(config, *client, "")
138-
139-
assert.Equal(t, "http://example.com", sink.Endpoint)
140-
assert.Equal(t, client, &sink.Client)
127+
sink := &SlackSink{}
128+
client := NewClient(2 * time.Second)
129+
config := v1alpha1.K8sGPT{
130+
Spec: v1alpha1.K8sGPTSpec{
131+
Sink: &v1alpha1.WebhookRef{
132+
Endpoint: "http://example.com",
133+
},
134+
},
135+
}
136+
137+
sink.Configure(config, *client, "")
138+
139+
assert.Equal(t, "http://example.com", sink.Endpoint)
140+
assert.Equal(t, client, &sink.Client)
141141
}
142142

143143
func Test_SlackSinkEmit(t *testing.T) {
144-
tests := []struct {
145-
name string
146-
results v1alpha1.ResultSpec
147-
responseCode int
148-
expectError bool
149-
}{
150-
{
151-
name: "Successful response",
152-
results: v1alpha1.ResultSpec{
153-
Kind: "kind",
154-
Name: "name",
155-
},
156-
responseCode: http.StatusOK,
157-
expectError: false,
158-
},
159-
{
160-
name: "Failed response",
161-
results: v1alpha1.ResultSpec{
162-
Kind: "kind",
163-
Name: "name",
164-
},
165-
responseCode: http.StatusInternalServerError,
166-
expectError: true,
167-
},
168-
}
169-
170-
for _, tt := range tests {
171-
t.Run(tt.name, func(t *testing.T) {
172-
sink := &SlackSink{
173-
Endpoint: "",
174-
Client: *NewClient(2 * time.Second),
175-
}
176-
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
177-
w.WriteHeader(tt.responseCode)
178-
}))
179-
defer server.Close()
180-
181-
sink.Endpoint = server.URL
182-
183-
err := sink.Emit(tt.results)
184-
185-
if tt.expectError {
186-
assert.Error(t, err)
187-
} else {
188-
assert.NoError(t, err)
189-
}
190-
})
191-
}
192-
}
144+
tests := []struct {
145+
name string
146+
results v1alpha1.ResultSpec
147+
responseCode int
148+
expectError bool
149+
}{
150+
{
151+
name: "Successful response",
152+
results: v1alpha1.ResultSpec{
153+
Kind: "kind",
154+
Name: "name",
155+
},
156+
responseCode: http.StatusOK,
157+
expectError: false,
158+
},
159+
{
160+
name: "Failed response",
161+
results: v1alpha1.ResultSpec{
162+
Kind: "kind",
163+
Name: "name",
164+
},
165+
responseCode: http.StatusInternalServerError,
166+
expectError: true,
167+
},
168+
}
169+
170+
for _, tt := range tests {
171+
t.Run(tt.name, func(t *testing.T) {
172+
sink := &SlackSink{
173+
Endpoint: "",
174+
Client: *NewClient(2 * time.Second),
175+
}
176+
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
177+
w.WriteHeader(tt.responseCode)
178+
}))
179+
defer server.Close()
180+
181+
sink.Endpoint = server.URL
182+
183+
err := sink.Emit(tt.results)
184+
185+
if tt.expectError {
186+
assert.Error(t, err)
187+
} else {
188+
assert.NoError(t, err)
189+
}
190+
})
191+
}
192+
}

‎pkg/sinks/slack.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,4 +78,3 @@ func (s *SlackSink) Emit(results v1alpha1.ResultSpec) error {
7878

7979
return nil
8080
}
81-

0 commit comments

Comments
 (0)