From 5a51952040a6b3abfeef520189d22f4bc1c630f6 Mon Sep 17 00:00:00 2001
From: Miguel Duarte Barroso <mdbarroso@redhat.com>
Date: Fri, 4 Nov 2022 13:30:01 +0100
Subject: [PATCH] ci, e2e tests: override the lower device name via env var

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
---
 .github/workflows/e2e-containerd.yaml |  1 +
 e2e/e2e_test.go                       | 23 +++++++++++++++++------
 2 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/e2e-containerd.yaml b/.github/workflows/e2e-containerd.yaml
index 355c3538..1995bfad 100644
--- a/.github/workflows/e2e-containerd.yaml
+++ b/.github/workflows/e2e-containerd.yaml
@@ -34,6 +34,7 @@ jobs:
       - name: Run e2e tests
         env:
           KUBECONFIG: /home/runner/.kube/config
+          LOWER_DEVICE: eth1
         run: make e2e/test
 
       - name: Cleanup cluster
diff --git a/e2e/e2e_test.go b/e2e/e2e_test.go
index 5563e573..8ed08867 100644
--- a/e2e/e2e_test.go
+++ b/e2e/e2e_test.go
@@ -26,10 +26,9 @@ func TestDynamicNetworksControllerE2E(t *testing.T) {
 
 var _ = Describe("Multus dynamic networks controller", func() {
 	const (
-		defaultLowerDeviceIfaceName = "eth0"
-		namespace                   = "ns1"
-		networkName                 = "tenant-network"
-		podName                     = "tiny-winy-pod"
+		namespace   = "ns1"
+		networkName = "tenant-network"
+		podName     = "tiny-winy-pod"
 	)
 	var clients *client.E2EClient
 
@@ -47,7 +46,7 @@ var _ = Describe("Multus dynamic networks controller", func() {
 		BeforeEach(func() {
 			_, err := clients.AddNamespace(namespace)
 			Expect(err).NotTo(HaveOccurred())
-			_, err = clients.AddNetAttachDef(macvlanNetworkWithoutIPAM(networkName, namespace, defaultLowerDeviceIfaceName))
+			_, err = clients.AddNetAttachDef(macvlanNetworkWithoutIPAM(networkName, namespace, lowerDeviceName()))
 			Expect(err).NotTo(HaveOccurred())
 		})
 
@@ -131,7 +130,7 @@ var _ = Describe("Multus dynamic networks controller", func() {
 				macAddress := "02:03:04:05:06:07"
 
 				BeforeEach(func() {
-					_, err := clients.AddNetAttachDef(macvlanNetworkWitStaticIPAM(ipamNetworkToAdd, namespace, defaultLowerDeviceIfaceName))
+					_, err := clients.AddNetAttachDef(macvlanNetworkWitStaticIPAM(ipamNetworkToAdd, namespace, lowerDeviceName()))
 					Expect(err).NotTo(HaveOccurred())
 					Expect(clients.AddNetworkToPod(pod, &nettypes.NetworkSelectionElement{
 						Name:             ipamNetworkToAdd,
@@ -329,3 +328,15 @@ func namespacedName(namespace, name string) string {
 func ipWithMask(ip string, netmaskLen int) string {
 	return fmt.Sprintf("%s/%d", ip, netmaskLen)
 }
+
+func lowerDeviceName() string {
+	const (
+		defaultLowerDeviceIfaceName = "eth0"
+		lowerDeviceEnvVarKeyName    = "LOWER_DEVICE"
+	)
+
+	if lowerDeviceIfaceName, wasFound := os.LookupEnv(lowerDeviceEnvVarKeyName); wasFound {
+		return lowerDeviceIfaceName
+	}
+	return defaultLowerDeviceIfaceName
+}