-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding webhook 'delete' command to remove non-namespaced objects #791
Open
heyvister1
wants to merge
6
commits into
k8snetworkplumbingwg:master
Choose a base branch
from
heyvister1:webhooks-k8s-objects-deletion
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding webhook 'delete' command to remove non-namespaced objects #791
heyvister1
wants to merge
6
commits into
k8snetworkplumbingwg:master
from
heyvister1:webhooks-k8s-objects-deletion
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
rollandf
reviewed
Oct 14, 2024
deployment/sriov-network-operator-chart/templates/pre-delete-webooks.yaml
Outdated
Show resolved
Hide resolved
zeeke
reviewed
Oct 14, 2024
heyvister1
force-pushed
the
webhooks-k8s-objects-deletion
branch
from
October 15, 2024 06:00
6877210
to
663ad6b
Compare
heyvister1
force-pushed
the
webhooks-k8s-objects-deletion
branch
from
October 15, 2024 06:27
663ad6b
to
450514e
Compare
Pull Request Test Coverage Report for Build 11459784654Details
💛 - Coveralls |
deployment/sriov-network-operator-chart/templates/pre-delete-webooks.yaml
Outdated
Show resolved
Hide resolved
deployment/sriov-network-operator-chart/templates/pre-delete-webooks.yaml
Show resolved
Hide resolved
heyvister1
force-pushed
the
webhooks-k8s-objects-deletion
branch
3 times, most recently
from
October 20, 2024 15:21
52d9671
to
693e48d
Compare
heyvister1
force-pushed
the
webhooks-k8s-objects-deletion
branch
from
October 20, 2024 15:25
693e48d
to
bd8a6fc
Compare
/test-all |
deployment/sriov-network-operator-chart/templates/pre-delete-webooks.yaml
Outdated
Show resolved
Hide resolved
generated cluster wise objects (e.g Mutating/Validating/ClusterRoles/ClusterRoleBinding). webhook delete command can be used with Helm unintall pre-delete hook, to cleanup remaining non-namespaced objects Signed-off-by: Ido Heyvi <iheyvi@nvidia.com>
Signed-off-by: Ido Heyvi <iheyvi@nvidia.com>
Signed-off-by: Ido Heyvi <iheyvi@nvidia.com>
webhooks objects removal by sriov operator Signed-off-by: Ido Heyvi <iheyvi@nvidia.com>
heyvister1
force-pushed
the
webhooks-k8s-objects-deletion
branch
2 times, most recently
from
October 22, 2024 07:40
13b3cda
to
e2440c4
Compare
heyvister1
force-pushed
the
webhooks-k8s-objects-deletion
branch
from
October 22, 2024 07:42
e2440c4
to
a7f10f2
Compare
zeeke
reviewed
Oct 22, 2024
zeeke
reviewed
Oct 22, 2024
deployment/sriov-network-operator-chart/templates/pre-delete-webooks.yaml
Show resolved
Hide resolved
heyvister1
force-pushed
the
webhooks-k8s-objects-deletion
branch
2 times, most recently
from
October 22, 2024 12:06
2ee6dad
to
56a8346
Compare
/test-all |
heyvister1
force-pushed
the
webhooks-k8s-objects-deletion
branch
from
October 22, 2024 14:03
56a8346
to
b44d847
Compare
heyvister1
force-pushed
the
webhooks-k8s-objects-deletion
branch
from
October 22, 2024 14:14
ec25c78
to
798f5e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sriov-network-operator dynamically creates
validating/mutating/clusterroles/clusterrolebinding
cluster objects, for specifiedSriovOperatorConfig
. These objects are not being cleaned once sriov operator is uninstalled (via Helm/Openshift).The proposed PR is to use a small go binary within Helm pre-delete hook. This binary will delete
default
SriovOperatorConfig, assuming added SriovOperatorConfig finalizer will make sure sriov controller is deleting all generated cluster level objects (e.g. webhooks), prior to operator deployment object is removed by Helm