-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Status update calls #669
Labels
Comments
burmanm
added a commit
to burmanm/cass-operator
that referenced
this issue
Jul 12, 2024
5 tasks
adejanovski
added
review
Issues in the state 'review'
and removed
in-progress
Issues in the state 'in-progress'
labels
Jul 12, 2024
adejanovski
added
ready-for-review
Issues in the state 'ready-for-review'
and removed
review
Issues in the state 'review'
labels
Jul 12, 2024
adejanovski
added
review
Issues in the state 'review'
and removed
ready-for-review
Issues in the state 'ready-for-review'
labels
Jul 12, 2024
adejanovski
added
ready-for-review
Issues in the state 'ready-for-review'
and removed
review
Issues in the state 'review'
labels
Jul 12, 2024
adejanovski
added
review
Issues in the state 'review'
and removed
ready-for-review
Issues in the state 'ready-for-review'
labels
Jul 12, 2024
adejanovski
added
ready-for-review
Issues in the state 'ready-for-review'
and removed
review
Issues in the state 'review'
labels
Jul 12, 2024
adejanovski
added
review
Issues in the state 'review'
and removed
ready-for-review
Issues in the state 'ready-for-review'
labels
Jul 12, 2024
adejanovski
added
review
Issues in the state 'review'
and removed
ready-for-review
Issues in the state 'ready-for-review'
labels
Jul 12, 2024
adejanovski
added
ready-for-review
Issues in the state 'ready-for-review'
and removed
review
Issues in the state 'review'
labels
Jul 12, 2024
adejanovski
added
review
Issues in the state 'review'
and removed
ready-for-review
Issues in the state 'ready-for-review'
labels
Jul 12, 2024
adejanovski
added
ready-for-review
Issues in the state 'ready-for-review'
review
Issues in the state 'review'
and removed
review
Issues in the state 'review'
ready-for-review
Issues in the state 'ready-for-review'
labels
Jul 12, 2024
adejanovski
added
ready-for-review
Issues in the state 'ready-for-review'
and removed
review
Issues in the state 'review'
labels
Jul 12, 2024
adejanovski
added
review
Issues in the state 'review'
and removed
ready-for-review
Issues in the state 'ready-for-review'
labels
Jul 17, 2024
burmanm
added a commit
to burmanm/cass-operator
that referenced
this issue
Jul 18, 2024
burmanm
added a commit
that referenced
this issue
Jul 18, 2024
* Refactor statusConditions updates, Fixes #669 * Add new metrics for all the condition statuses as well as OperatorProgress * Remove task metrics for now * Add CHANGELOG
adejanovski
added
done
Issues in the state 'done'
and removed
review
Issues in the state 'review'
labels
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
What is missing?
What we want from the code is to keep the CassandraDatacenter Status as descriptive of the state of the reconciliation. However, that has caused a repetition of the same code all over the codebase:
While it works, this takes a lot of lines and makes the code look messy (with some silly structural hacks to make Patch happen only once). Instead, the rc.setCondition() should probably do this directly, or even masquerade the NewDatacenterCondition call at the same time. Or do the Status Patching itself on one centralized place, although that could be a lot larger refactoring, so first step could be do to it in the setCondition and then later make that patch happen somewhere else.
Why is this needed?
For easier maintenance.
The text was updated successfully, but these errors were encountered: