Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile uses an outdated lint version #692

Closed
olim7t opened this issue Aug 28, 2024 · 0 comments · Fixed by #693
Closed

Makefile uses an outdated lint version #692

olim7t opened this issue Aug 28, 2024 · 0 comments · Fixed by #693
Assignees
@olim7t
Labels
done Issues in the state 'done'

Comments

@olim7t
Copy link
Contributor

olim7t commented Aug 28, 2024

The Makefile uses golint 1.59.1, while the Github action in CI uses 1.60.3.

1.60.3 is more strict, it reports errors that prevent the rest of the CI job from running (unit tests, publishing a dev Docker image, etc).
olim7t added a commit to olim7t/cass-operator that referenced this issue Aug 28, 2024
@olim7t
Upgrade golint and fix errors (fixes k8ssandra#692)
635f9c0
@olim7t olim7t mentioned this issue Aug 28, 2024
Merged
5 tasks
@olim7t olim7t moved this to Ready For Review in K8ssandra Aug 29, 2024
@adejanovski adejanovski added the ready-for-review Issues in the state 'ready-for-review' label Aug 29, 2024
@olim7t olim7t self-assigned this Aug 29, 2024
@burmanm burmanm moved this from Ready For Review to Review in K8ssandra Aug 30, 2024
@adejanovski adejanovski added review Issues in the state 'review' and removed ready-for-review Issues in the state 'ready-for-review' labels Aug 30, 2024
burmanm pushed a commit that referenced this issue Aug 30, 2024
@olim7t
Upgrade golint and fix errors (fixes #692) (#693)
ddd1e65 
* Upgrade golint and fix errors (fixes #692)

* Fix failing test
@github-project-automation github-project-automation bot moved this from Review to Done in K8ssandra Aug 30, 2024
@adejanovski adejanovski added done Issues in the state 'done' and removed review Issues in the state 'review' labels Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olim7t olim7t

Labels
done Issues in the state 'done'
Projects
No open projects
K8ssandra
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade golint and fix errors (fixes #692) olim7t/cass-operator
2 participants
@olim7t @adejanovski