Replies: 1 comment
-
My preference goes out to 1 lib overall, like nr. 2. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I ran in my testproject, transfer.ts into the PactNumber. I see two options
PactNumber
from@kadena/pactjs
PactNumber
in@kadena/client
and the consuming library imports from@kadena/client
1. we have less control on the versions that users use. They can mix and match different versions together. The consumer needs to make sure to use compatible versions. We can provide
peerDependencies
in@kadena/client
for@kadena/pactjs
(e.g.@kadena/pactjs@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev
) and other libraries.2. we decide what version of
@kadena/pactjs
(or other dependencies) to use and export ourselves inindex.ts
export * from '@kadena/pactjs'
. The consumer has now one library to use. They cannot mix and match other versions.For us this is easier to maintain, because our tests will validate if the combination used will work. No issues in the community of "which version works where". We can push refactorings easier when we expose one "entry library" (i.e.
@kadena/client
)Beta Was this translation helpful? Give feedback.
All reactions