Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Validation Error] Report why tx failed the buy gas attempt #890

Closed
LindaOrtega opened this issue Jan 22, 2020 · 0 comments · Fixed by #893
Closed

[Validation Error] Report why tx failed the buy gas attempt #890

LindaOrtega opened this issue Jan 22, 2020 · 0 comments · Fixed by #893
Labels
component: mempool component: pact-service The Pact Service, or Pact language updates in general. good first issue Good for newcomers

Comments

@LindaOrtega
Copy link
Contributor

Potentially related to #753

Users often get

"Validation failed for hash "6tpv9gbfFuEK57XDzB07OZuUGF1ngY3helQYnDpbpy0": Sender account has insufficient gas."

when they submit a transaction that fails a dry-run attempt to buy gas.

We should improve this error message to explain why the transaction failed the buy gas check.

Relevant code sections:
Error message specified.
https://github.com/kadena-io/chainweb-node/blob/master/src/Chainweb/Pact/PactService.hs#L675

Error type thrown in attemptBuyGas function.
https://github.com/kadena-io/chainweb-node/blob/master/src/Chainweb/Mempool/Mempool.hs#L216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: mempool component: pact-service The Pact Service, or Pact language updates in general. good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More detailed errors when attempt buy gas fails kadena-io/chainweb-node
1 participant
@LindaOrtega