-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari, iOS Companion App: glitches when "fill: fade" & using "decluttering-card" #839
Comments
Issue is caused by |
Absolutely agree - this is a Created an issue - custom-cards/decluttering-card#55 |
Issued a fix in Earlier only experienced the issue in Safari (observed in MacOS 10.x & iOS 15.x) or iOS Companion App.
test view:
Result in Chrome: See no issue in iOS Companion App (iOS 15.7.x). |
Found a rather serious bug.
It occurs when:
--
fill: fade
;-- the
mini-graph-card
is placed inside acustom:decluttering-card
;-- there are at least 2 cards on the view with different
height
.-- using Safari (observed in MacOS 10.x & iOS 15.x) or iOS Companion App.
Here is a code for a decluttering template (put your own sensor):
and for the test view:
The view contains 2 stacks:
-- two
mini-graph-card
insidedeclutering-card
- with different heights;-- two
mini-graph-card
- with different heights.How it looks in Chrome+Win:

And how it looks in Safari:

There is a glitch on the top-left card - the "fill" seems to occupy just a half of the area.
As a workaround - use "fill: true".
Or do not use Safari & iOS Companion App.
A possible reason is described below.
The graph contains of three objects:
-- the graph's line;
-- the graph's points;
-- the graph's fill.
If the card contains several entities - then it contains several sets of those objects (line, points, fill).

To differ objects belonging to different entities, the code uses a unique ID:
containing a unique string and some index (0 - 1st entity, 1 - 2nd entity, ...).
The unique string seems to be some kind of "this card unique ID".
But when placed inside a

decluttering-card
, these IDs are same:The
declutter-child-
part is always same.Means - if several cards are present on the view, a wrong fill mask may be selected.
A possible fix should be generating a unique ID.
The text was updated successfully, but these errors were encountered: