Skip to content

Commit e250dd0

Browse files
authored
fix(ADA-1062): Change role on Advanced captions settings (#897)
### Description of the Changes **Issue:** The "Advanced captions settings on captions menu has role="menuitemradio" but the option cannot be checked. **Fix:** Change role to "menuitem" so that the SR will not announce the option as a checked/not checked option. #### Resolves [ADA-1062](https://kaltura.atlassian.net/browse/ADA-1062) [ADA-1062]: https://kaltura.atlassian.net/browse/ADA-1062?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent 324e30d commit e250dd0

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/components/captions-menu/captions-menu.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ class CaptionsMenu extends Component<any, any> {
8585
.sort((a, b) => (a.label > b.label || a.label === 'Off' ? 1 : -1));
8686

8787
if (props.showAdvancedCaptionsMenu) {
88-
textOptions.push({label: props.advancedCaptionsSettingsText, value: props.advancedCaptionsSettingsText, active: false});
88+
textOptions.push({label: props.advancedCaptionsSettingsText, value: props.advancedCaptionsSettingsText, active: false, isAdvanced: true});
8989
}
9090

9191
if (this.props.asDropdown) {

src/components/menu/menu.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,8 @@ class Menu extends Component<MenuProps & WithEventManagerProps, any> {
198198
*/
199199
render(props: any): VNode<any> {
200200
props.clearAccessibleChildren();
201+
const menuItemRole = "menuitem";
202+
const menuItemRadioRole = "menuitemradio";
201203
return props.isMobile || props.isSmallSize ? (
202204
this.renderNativeSelect(props.labelledby)
203205
) : (
@@ -217,6 +219,7 @@ class Menu extends Component<MenuProps & WithEventManagerProps, any> {
217219
}}
218220
key={index}
219221
data={o}
222+
role={o?.isAdvanced ? menuItemRole : menuItemRadioRole}
220223
/>
221224
))}
222225
</div>
@@ -273,7 +276,7 @@ class MenuItem extends Component<any, any> {
273276
props.data.badgeType && !props.isSelected(props.data) ? BadgeType[props.data.badgeType] : BadgeType[props.data.badgeType + 'Active'];
274277
return (
275278
<div
276-
role="menuitemradio"
279+
role={props?.role}
277280
tabIndex={-1}
278281
aria-checked={props.isSelected(props.data) ? 'true' : 'false'}
279282
ref={element => {

0 commit comments

Comments
 (0)