From da61ad7067678240feb09cce6045f2333a117669 Mon Sep 17 00:00:00 2001 From: Sergei Zaychenko Date: Thu, 10 Oct 2024 01:23:14 -0700 Subject: [PATCH] Workaround in failing e2e test: await until outbox is flushed after creating a dataset --- .../datasets/services/src/dataset_entry_service_impl.rs | 2 ++ src/e2e/app/cli/repo-tests/src/test_rest_api.rs | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/src/domain/datasets/services/src/dataset_entry_service_impl.rs b/src/domain/datasets/services/src/dataset_entry_service_impl.rs index 057e5b9b7..207ee89ac 100644 --- a/src/domain/datasets/services/src/dataset_entry_service_impl.rs +++ b/src/domain/datasets/services/src/dataset_entry_service_impl.rs @@ -304,6 +304,7 @@ impl DatasetEntryService for DatasetEntryServiceImpl { #[async_trait::async_trait] impl DatasetRegistry for DatasetEntryServiceImpl { + #[tracing::instrument(level = "debug", skip_all)] fn get_all_datasets(&self) -> DatasetHandleStream<'_> { Box::pin(async_stream::try_stream! { // Tracking pagination progress @@ -336,6 +337,7 @@ impl DatasetRegistry for DatasetEntryServiceImpl { }) } + #[tracing::instrument(level = "debug", skip_all, fields(%dataset_ref))] async fn resolve_dataset_ref( &self, dataset_ref: &DatasetRef, diff --git a/src/e2e/app/cli/repo-tests/src/test_rest_api.rs b/src/e2e/app/cli/repo-tests/src/test_rest_api.rs index 2cbf04a80..fa8f914ff 100644 --- a/src/e2e/app/cli/repo-tests/src/test_rest_api.rs +++ b/src/e2e/app/cli/repo-tests/src/test_rest_api.rs @@ -27,6 +27,10 @@ pub async fn test_rest_api_request_dataset_tail(kamu_api_server_client: KamuApiS .create_player_scores_dataset(&token) .await; + // Workarround: await outbox, we should save a DatasetEntry before query start + // TODO: invent a way to flush outbox in e2e tests or to shorten waiting cycles + tokio::time::sleep(std::time::Duration::from_secs(2)).await; + // 3. Try to get the dataset tail kamu_api_server_client .rest_api_call_assert(