Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: App is sometimes slow to close (takes several seconds) #43

Open
dbarnett opened this issue Feb 28, 2024 · 3 comments
Open

Comments

@dbarnett
Copy link
Contributor

I've noticed the app is surprisingly slow and in some cases even takes several seconds to close after I click the X button.

There's no noticeable delay if I just open the app, wait for the main UI to load, and then click X. If I start a SQLite connection and then close the app, it does seem to consistently hang for a couple seconds (which could conceivably take a little time to close a DB connection, but still feels excessive taking several seconds in the case of a local SQLite file). But also even if I just start the connection dialog for a SQLite connection, quit out of the file picker, and close the app, that still seems to take the same several seconds to exit... in that case I can't imagine why.

@kareemmahlees
Copy link
Owner

Are you in dev, debug or build mode?

@dbarnett
Copy link
Contributor Author

I noticed it from the installed deb downloaded from the site and then reproduced similar in dev mode.

I can definitely dig deeper into causes later, just noting some observations for now.

@kareemmahlees
Copy link
Owner

Initial thoughts without testing anything, I think the problem might be in the logic of cleanup, specifically while killing the sidecar command child.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants