Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly calculate page number in table pagination 🐛 #109

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

kareemmahlees
Copy link
Owner

Bug description

Previously, there was a missing page ( the last page ) in table pagination, because during calculating the page count, I used a naive division instead of div_ceiling it.

@kareemmahlees kareemmahlees added bug Something isn't working desktop Desktop application related changes. labels Sep 16, 2024
@kareemmahlees kareemmahlees merged commit 97cbc0b into master Sep 17, 2024
12 checks passed
@kareemmahlees kareemmahlees deleted the fix/pagination-flooring branch September 17, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working desktop Desktop application related changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant