Can't start Firefox Nightly

[konorlevich]

OS: Ubuntu 17.10
Node: 8.9.3
npm: 5.6
@angular/cli: 1.6.1
Karma: 1.7.1
"karma-firefox-launcher": "~1.1.0"

firefox-trunk: Mozilla Firefox 59.0a1
was installed by following commands
sudo add-apt-repository ppa:ubuntu-mozilla-daily/ppa
sudo apt-get update
sudo apt-get install firefox-trunk

>ng test

10% building modules 1/1 modules 0 active
16 12 2017 17:27:28.126:WARN [karma]: No captured browser, open http://localhost:9876/
16 12 2017 17:27:28.132:INFO [karma]: Karma v1.7.1 server started at http://0.0.0.0:9876/
16 12 2017 17:27:28.132:INFO [launcher]: Launching browser FirefoxNightly with unlimited concurrency
16 12 2017 17:27:28.137:INFO [launcher]: Starting browser FirefoxNightly
16 12 2017 17:27:31.051:WARN [karma]: No captured browser, open http://localhost:9876/

[gluons]

Same on Windows.

On Windows, it uses this:

karma-firefox-launcher/index.js

Line 215 in cf20be3

win32: getFirefoxExe('Nightly')

And

karma-firefox-launcher/index.js

Lines 57 to 66 in cf20be3

	var suffix = '\\' + firefoxDirName + '\\firefox.exe'
	for (var i = 0; i < prefixes.length; i++) {
	prefix = prefixes[i]
	if (fs.existsSync(prefix + suffix)) {
	return prefix + suffix
	}
	}
	return 'C:\\Program Files' + suffix

So the final path is C:\\Program Files\\Nightly\\firefox.exe.
But I just install fresh Nightly on Windows 10. My Nightly located at C:\Program Files\Firefox Nightly\firefox.exe.

[sasaxing]

firefoxDirName seems not correct. On OSX FirefoxNightly is installed in a directory whose name has a space in between: Firefox Nightly.app.
Not sure about windows, but it looks like the same issue.

[birtles]

I have a fix for this as part of birtles@da4e43b but I'm currently trying to resolve #93 before putting any of that up for review.

[birtles]

This should now be fixed for Windows and Mac by 6377ee3 but I need to setup a Linux environment to check if firefox-trunk is still the binary name in more recent versions of Nightly.