-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add error level flag #657
Comments
@danh91 can you give some input on how you would like this to be implemented? |
Hi @jacobshilitz, Yes, adding an optional karrio/modules/sdk/karrio/core/models.py Lines 239 to 246 in 330a6b9
So that every carrier integration can adopt it progressively on there error parsing functions. e.g. pass the level to the Message type karrio/modules/connectors/fedex/karrio/providers/fedex/error.py Lines 48 to 62 in 330a6b9
The only thing is we need to standardize the levels with an enum like
The enum can be in the sdk/karrio/core/units.py file. These are the ones I have seen in general. What do you think? |
Is your feature request related to a problem? Please describe.
Some carriers return notes and warnings which are not errors, but they can be useful.
for example, FedEx we disabled the "note" type messages because it was not an error, see commit 4d2a07b.
Describe the solution you'd like
Add a level to message object that indicates whether it's an error or just a notice.
and add support for all the carriers
I thought it can maybe also be a setting in the user or in the API in each call, what errors should be suppressed
The text was updated successfully, but these errors were encountered: