-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<iframe>
inside ShadowDOM will cause extension script hang
#105
Comments
Thank you for the report, we'll fix it and include it in the upcoming releases. |
Any updates? |
This issue is still occurring with Chrome extension 5.8.1 and my shadow dom that I am attempting to record does NOT have an iframe in it. In fact, it breaks the shadow dom causing the browser to freeze and having to force quit the entire browser without even trying to record. Had to turn off the extension to stop it from breaking the shadow dom. This is occurring on both Mac (Chrome v. 101) and Windows(Chrome v. 89) in either incognito or regular. |
Hello, could you fix this in a next release? Another user of my extension also met this crash. |
Platform: Chrome 94, Win 10 / macOS 11.4
Extension: Katalon Recorder (Selenium tests generator) 5.5.4.8
One line description
If a page creates a
Shadow DOM
tree and then insert<iframe></iframe>
into the tree, then this extension's content script will enter a dead loop and the whole page hangs.Test steps
A simple test is: install
Vimium C
(https://github.com/gdh1995/vimium-c) and press/
on a Google page. If without this extension, Vimium C should show a small input box at the bottom right corner and a user can type letters to search.But with this enabled, a test page will hang (as reported in gdh1995/vimium-c#457).
Buggy point
katalon-recorder/content/recorder.js
Lines 89 to 98 in d118f95
Here
frames
won't include child frames insideShadow DOM
trees, socurrentWindow
won't be updated, and thencurrentWindow !== window.top
is alwaystrue
.The text was updated successfully, but these errors were encountered: