New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDPG Vanilla uses next_states where this is using states #2

Open

jensakut opened this issue May 18, 2020 · 0 comments

jensakut commented May 18, 2020

Hi

DDPG Vanilla around line 90 uses next_states
https://github.com/udacity/deep-reinforcement-learning/blob/master/ddpg-bipedal/ddpg_agent.py#L94
whereas this implementation uses states :-)

unityml-tennis/maddpg.py

Line 185 in d1533fd

next_actions[:, i] = agent.target_actor(states[:, i, :])

is this intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment