[Fix]#115/ハイパーリンクの受信側の表示エラー #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チャットメッセージのハイパーリンクの受信側の表示エラーを解消。
https://github.comというメッセージを送信した際の相手の表示が以下となっていた。
https://github.com/'' target='_blank'>https://github.com/' target='_blank'>https://github.com/
原因は、左右両方のパーシャルで呼び出しているため、
<%= content_url_to_link(content).html_safe %>
送信（右のパーシャル）で破壊的メソッドでcontentの内容を書き換えて、さらに左で書き換えているからリロードしないと2重になる。
dupメソッドでコピーして書き換えるcontentを複数用意して二重の処理を防ぐ。
少々力技の感じがあるため、破壊的メソッドを使わない方法で改善予定。