Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API /job/id/assemblies/* deprecated? #121

Closed
levinas opened this issue Jul 3, 2014 · 3 comments
Closed

REST API /job/id/assemblies/* deprecated? #121

levinas opened this issue Jul 3, 2014 · 3 comments

Comments

@levinas
Copy link
Contributor

levinas commented Jul 3, 2014

It's broken, but I think the functions are well covered by the new tags and type options in the results endpoint.

curl http://localhost:8000/user/fangfang/job/60/results?type=contigs,scaffolds
curl http://localhost:8000/user/fangfang/job/60/results?tags=rank-1

The question is whether we should just remove them. Or I could just implement it using get_results().

Description of the original assemblies/* endpoints in #45.

@levinas levinas added this to the Functions for RAST2 demo milestone Jul 3, 2014
@levinas
Copy link
Contributor Author

levinas commented Jul 3, 2014

I will implement the following mapping:

Client call REST endpoint Server-side implementation
get --pick n assemblies/n results?tags=quast-n
get --pick velvet assemblies/velvet results?tags=velvet
get --pick assemblies/auto results?tags=rank-1
get --assembly assemblies/ results?type=contigs

@levinas
Copy link
Contributor Author

levinas commented Jul 8, 2014

Decision: keep assemblies/ routes.

@levinas levinas closed this as completed Jul 8, 2014
@levinas
Copy link
Contributor Author

levinas commented Jul 8, 2014

See comments in:

#122

@sebhtml sebhtml changed the title REST API /job/id/assemblies/* deprecated? Is REST API /job/id/assemblies/* deprecated? Jul 8, 2014
@sebhtml sebhtml changed the title Is REST API /job/id/assemblies/* deprecated? REST API /job/id/assemblies/* deprecated? Jul 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant