Skip to content

bug: TokenReviews not working with WorkspaceAuthentication #3614

@xrstf

Description

@xrstf

Describe the bug

The TokenReview handler in the k/k code has no knowledge about the cluster, and so the workspace authenticator cannot determine the authn. This makes it so that a TokenReview is always resulting in a HTTP 401 "invalid bearer token".

We should adjust our k/k fork to ensure the target cluster is available in the fakeRequest that the TokenReview handler creates and hands over to the tokenAuthenticator.

Steps To Reproduce

N/A

Expected Behaviour

TokenReviews should work as expected.

Additional Context

No response

Metadata

Metadata

Assignees

Labels

kind/bugCategorizes issue or PR as related to a bug.

Type

No type

Projects

Status

In Progress

Relationships

None yet

Development

No branches or pull requests

Issue actions