From 36b98d80c7c7b093feb8dd6dbf1f1b598da168cd Mon Sep 17 00:00:00 2001 From: Gemini Agent Date: Fri, 20 Feb 2026 20:39:50 +0100 Subject: [PATCH] Fix CI: deploy jobs skipped on push to main due to skipped reviewer ancestors GitHub Actions skips downstream jobs when any transitive dependency was skipped, even if the direct dependency succeeded. Since ai-review and security-review are skipped on push (PR-only), deploy-staging and all subsequent jobs were skipped too. Fix: add 'if: always() && needs..result == success' to deploy-staging, e2e-tests-staging, and deploy-production so they run when their direct dependency succeeds regardless of skipped ancestors. --- .github/workflows/ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 156018f..fb38887 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -204,6 +204,7 @@ jobs: # ============================================ deploy-staging: needs: build + if: always() && needs.build.result == 'success' runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 @@ -233,6 +234,7 @@ jobs: # ============================================ e2e-tests-staging: needs: deploy-staging + if: always() && needs.deploy-staging.result == 'success' runs-on: ubuntu-latest env: # Slack configuration (Pattern: {SERVICE}_{ENV}_*) @@ -295,7 +297,7 @@ jobs: # ============================================ deploy-production: needs: e2e-tests-staging - if: github.ref == 'refs/heads/main' + if: always() && needs.e2e-tests-staging.result == 'success' && github.ref == 'refs/heads/main' runs-on: ubuntu-latest steps: - uses: actions/checkout@v4