From 1d2496d3bf48f407da296243e3bcff241656aadc Mon Sep 17 00:00:00 2001 From: Ravi Kumar Pilla Date: Tue, 27 Feb 2024 08:24:10 -0600 Subject: [PATCH] Fix Lint and Windows build (#1763) * fix lint issue on main Signed-off-by: ravi-kumar-pilla * update win orb Signed-off-by: ravi-kumar-pilla * test conda env Signed-off-by: ravi-kumar-pilla * add install miniconda Signed-off-by: ravi-kumar-pilla * add install miniconda Signed-off-by: ravi-kumar-pilla * add install miniconda Signed-off-by: ravi-kumar-pilla * add install miniconda Signed-off-by: ravi-kumar-pilla * add install miniconda Signed-off-by: ravi-kumar-pilla * add install miniconda Signed-off-by: ravi-kumar-pilla * add install miniconda Signed-off-by: ravi-kumar-pilla * add install miniconda Signed-off-by: ravi-kumar-pilla * add install miniconda Signed-off-by: ravi-kumar-pilla * add install miniconda test1 Signed-off-by: ravi-kumar-pilla * using msft image Signed-off-by: ravi-kumar-pilla * using msft image Signed-off-by: ravi-kumar-pilla * remove msft image Signed-off-by: ravi-kumar-pilla * remove msft image Signed-off-by: ravi-kumar-pilla * reverting test changes Signed-off-by: ravi-kumar-pilla * revert test branch condition Signed-off-by: ravi-kumar-pilla --------- Signed-off-by: ravi-kumar-pilla --- .circleci/continue_config.yml | 11 ++++++----- package/kedro_viz/data_access/repositories/graph.py | 3 +-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.circleci/continue_config.yml b/.circleci/continue_config.yml index 6a9a8b0cac..2e7bae4e44 100755 --- a/.circleci/continue_config.yml +++ b/.circleci/continue_config.yml @@ -14,7 +14,7 @@ parameters: default: false orbs: - win: circleci/windows@2.4.1 + win: circleci/windows@4.1.1 node: circleci/node@5.0.3 # No windows executor is listed here since windows builds use win/default and modify @@ -73,15 +73,16 @@ commands: make build win_setup_python_env: - # Miniconda3 is pre-installed on the machine: - # https://circleci.com/docs/2.0/hello-world-windows/ parameters: python_version: type: string steps: - run: - name: Initialize conda - command: conda init powershell + name: Install and initialize Miniconda + command: | + choco install miniconda3 -y + refreshenv + C:\tools\miniconda3\Scripts\conda init powershell - run: name: Create 'kedro-viz' conda environment command: conda create --name kedro-viz python=<> -y diff --git a/package/kedro_viz/data_access/repositories/graph.py b/package/kedro_viz/data_access/repositories/graph.py index 2d4b02ac6a..90f734ec1d 100644 --- a/package/kedro_viz/data_access/repositories/graph.py +++ b/package/kedro_viz/data_access/repositories/graph.py @@ -43,8 +43,7 @@ def __init__(self): self.edges_list: Set[GraphEdge] = set() def __iter__(self) -> Generator: - for edge in self.edges_list: - yield edge + yield from self.edges_list def remove_edge(self, edge: GraphEdge): """Remove an edge from this edge repository.