Add Dev Containers config #2255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
astrojuanlu
force-pushed
the
dev-containers
branch
2 times, most recently
from
6fe1e31 to
7939a7c
Compare
|
Not so fast... see below |
| "onCreateCommand": "./.devcontainer/onCreateCommand.sh", | ||
|
|
||
| "postStartCommand": { | ||
| "backend": "nohup bash -c 'uv run python package/kedro_viz/server.py demo-project &' > backend.out 2> backend.err < /dev/null", |
There was a problem hiding this comment.
I am a little confused why this happens, from where does it get the build files?
There was a problem hiding this comment.
I think it's getting them from the published version 😓
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
force-pushed
the
dev-containers
branch
from
7939a7c to
337e753
Compare
astrojuanlu
commented
Feb 3, 2025
There was a problem hiding this comment.
I think this is not using the development version of Kedro-Viz, but the published one 😭
I know because I launched this from latest main after #2248 was merged and I don't see the deprecation warning.
|
Closing this for now, since it's not ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why was this PR created?
Gitpod has been up until now the preferred way to do QA of PRs without having to build a full development environment.
However, Gitpod Classic is going away, and we need to find another solution.
Gitpod Flex works with Dev Containers https://www.gitpod.io/blog/introducing-gitpod-flex#development-container-support so here is my first attempt to add Dev Containers config.
Development notes
This mostly works. But almost by chance...
The
backendcommand is succeeding. And somehow it's launching both the backend and the frontend? I don't fully understand why ❓I didn't see a
npm installstep anywhere listed in ourCONTRIBUTING.md(hitting #1764 again?) but I added to the dev container anyway, and looks like it's working.When I tried to configure the image to use NodeJS 18 though, I found some inconsistencies between what the IDE tells me and what the standards say.
I would like somebody else to pick this up if it's not too much to ask 🙏🏼
QA notes
https://code.visualstudio.com/docs/devcontainers/create-dev-container
Run the
>dev containers: rebuild and reopencommand and check that everything works.Checklist
RELEASE.mdfile