From e49102f95dc341d16a25a44860fa50401119e1d4 Mon Sep 17 00:00:00 2001 From: Jakub Nowakowski Date: Wed, 13 Jan 2021 12:39:33 +0100 Subject: [PATCH] Don't use npm update before publication In our projects we use `npm update` to resolve latest versions for prerelease packages from `@keep-network` scope that the current project depends on. In case of `sortition-pools` there are no dependencies to any contracts so we don't need to use `npm update`. What plain `npm update` did was updating all the packages we defined in dependencies that could cause problems as we were testing agains specific versions locked in package-lock and also CI executed it's tests agains them but here at the very last step before package publication we updated locked versions. If we need to update contracts dependencies in prerelease cycle we should specify which packages we want to update, e.g. `npm update @keep-network/sortition-pools`. --- .github/workflows/npm.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/npm.yml b/.github/workflows/npm.yml index 34abf14f..448c7ccc 100644 --- a/.github/workflows/npm.yml +++ b/.github/workflows/npm.yml @@ -66,9 +66,6 @@ jobs: # Consider including commit id? Would be +. npm version prerelease --preid=$preid --no-git-tag-version - # Fix resolved dependency versions. - npm update - - name: Publish package run: npm publish --access public env: