Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recolor Gradients limited to 8 Keys in a Gradient, work around needed. #17

Open
skyistumbling opened this issue Dec 6, 2020 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@skyistumbling
Copy link

skyistumbling commented Dec 6, 2020

I've been messing around with his awesome package for a while and found out a major limitation to this, since this is using the unity default Gradient tool it is limited to only have 8 Keys in a Gradient. For example if you're trying to do a toon look with the Recolor effects Fill and have the gradient to have a mode of Fixed you have to be very picky about which keys you have to use, thus preventing you from mapping out all the luminosities you need.

ijsitjwijtmijw

If it's possible, could splitting up the gradient into two separate ones be done?

Other than these little issues, I'd like to thank you for sharing this graphics toolset with us, it's been awesome to use so far, great job!

@keijiro keijiro self-assigned this Dec 6, 2020
@keijiro keijiro added the question Further information is requested label Dec 6, 2020
@keijiro
Copy link
Owner

keijiro commented Dec 6, 2020

Splitting the gradient into two separated gradients is technically possible, but does it actually work in UX wise? It also requires more shader variants (= more shader compilation time) and makes the shader slower than the current implementation. I think it's better to use other sophisticated methods like MatCap for such complex configurations.

@skyistumbling
Copy link
Author

skyistumbling commented Dec 6, 2020

That's a fair point yeah, or you could have a option to input a texture in place of the gradient? I'll definitely look into matcap but it seems like a hassle to setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants