Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #25

Closed
ccoVeille opened this issue Jun 30, 2024 · 4 comments · Fixed by #26
Closed

Improve CI #25

ccoVeille opened this issue Jun 30, 2024 · 4 comments · Fixed by #26

Comments

@ccoVeille
Copy link
Contributor

  • you should add a dependabot/renovatebot to your GitHub actions
  • golangci-lint should be part of the test to ensure the context quality of code.
@ccoVeille
Copy link
Contributor Author

I can help you of course

@kevincobain2000
Copy link
Owner

kevincobain2000 commented Jun 30, 2024

Hi
For dependabot - yes I should have been adding it. If you can add it quickly that is cool too, will appreciate it. I got little busy today with the #24

For golanglint-ci

Step 0) golanglint-ci - oops. I copied those from my previous project which had a lot of lint errors, so instead of failing I started counting the progress. Actually there are no errors on this repo - so I should update the following to fail on errors.

ASIS

      - name: Lint Errors
        uses: kevincobain2000/action-coveritup@v2
        with:
          type: go-lint-errors
          command: golangci-lint run ./... | grep  -c "\^"

TOBE

      - name: Lint Errors
        run: golangci-lint run ./...

- name: Lint Errors

Step 1) And finally update the README to remove the badges and graphs.

@kevincobain2000
Copy link
Owner

kevincobain2000 commented Jun 30, 2024

golanglint-ci fix is here: 6e9e34d as part of #24

@ccoVeille
Copy link
Contributor Author

I will add a dependabot not then.

I can also help by adding more linters to golangci-lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants