Skip to content

Latest commit

 

History

History
92 lines (68 loc) · 5.25 KB

CONTRIBUTING.md

File metadata and controls

92 lines (68 loc) · 5.25 KB
Raw

How To Contribute To Beaker

Getting Started

Making Changes

  • Create a topic branch from your fork of puppetlabs/beaker.
    • Please title the branch after the beaker ticket you intend to address, ie BKR-1234.
  • Make commits of logical units.
  • Check for unnecessary whitespace with git diff --check before committing.
  • Make sure your commit messages are in the proper format.
    (BKR-1234) Make the example in CONTRIBUTING imperative and concrete

    Without this patch applied the example commit message in the CONTRIBUTING
    document is not a concrete example.  This is a problem because the
    contributor is left to imagine what the commit message should look like
    based on a description rather than an example.  This patch fixes the
    problem by making the example concrete and imperative.

    The first line is a real life imperative statement with a ticket number
    from our issue tracker.  The body describes the behavior without the patch,
    why this is a problem, and how the patch fixes the problem when applied.
  • During the time that you are working on your patch the master Beaker branch may have changed - you'll want to rebase on top of Beaker's master branch before you submit your PR. A successful rebase ensures that your PR will cleanly merge into Beaker.

Testing

  • Submitted PR's will be tested in a series of spec and acceptance level tests - the results of these tests will be evaluated by a Beaker team member, as test results are currently not accessible by the public. Testing failures that require code changes will be communicated in the PR discussion.
  • Make sure you have added RSpec tests that exercise your new code. These test should be located in the appropriate beaker/spec/ subdirectory. The addition of new methods/classes or the addition of code paths to existing methods/classes requires additional RSpec coverage.
    • Beaker uses RSpec 3.1.0+, and you should NOT USE deprecated should/stub methods - USE expect/allow. See a nice blog post from 2013 on RSpec's new message expectation syntax.
    • Run the tests to assure nothing else was accidentally broken, using rake test
      • Bonus: if possible ensure that rake test runs without failures for additional Rubies (versions 1.9.3 and above).

Documentation

  • Add an entry in the CHANGELOG.md. Refer to the CHANGELOG itself for message style/form details.
  • Make sure that you have added documentation using Yard as necessary for any new code introduced.
  • More user friendly documentation will be required for PRs unless exempted. Documentation lives in the docs/ folder.

Making Trivial Changes

Maintenance

For changes of a trivial nature, it is not always necessary to create a new ticket in Jira. In this case, it is appropriate to start the first line of a commit with (MAINT) instead of a ticket/issue number.

    (MAINT) Fix whitespace 

    - remove additional spaces that appear at EOL

Version Bump For Gem Release

To prepare for a new gem release of Beaker the version.rb file is updated with the upcoming gem version number. This is submitted with (GEM) instead of a ticket/issue number.

     (GEM) Update version for Beaker 1.16.1

History File Update

To prepare for a new gem release of Beaker (after the version has been bumped) the HISTORY.md file is updated with the latest GitHub log. This is submitted with (HISTORY) instead of a ticket/issue number.

    (HISTORY) Update history for release of Beaker 1.16.1

Submitting Changes

  • Push your changes to a topic branch in your fork of the repository.
  • Submit a pull request to Beaker
  • Update your ticket
    • Update your Jira ticket to mark that you have submitted code and are ready for it to be considered for merge (Status: Ready for Merge).
      • Include a link to the pull request in the ticket.
  • PRs are reviewed as time permits.

Additional Resources