Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$$VERSION$$ in example yaml possibly not resolved #473

Closed
andreas-ibm opened this issue Aug 1, 2023 · 6 comments
Closed

$$VERSION$$ in example yaml possibly not resolved #473

andreas-ibm opened this issue Aug 1, 2023 · 6 comments
Labels

Comments

@andreas-ibm
Copy link

andreas-ibm commented Aug 1, 2023

Describe the bug

I'm no k8s expert, let's start with that!

I have a script that effectively follows https://www.keycloak.org/getting-started/getting-started-kube, so at one stage it runs:

kubectl create -f https://raw.githubusercontent.com/keycloak/keycloak-quickstarts/latest/kubernetes/keycloak.yaml

which used to work fine, but since #458 and #459 it doesn't...

If I manually download the yaml and replace $$VERSION$$ with the latest version it works again, so I'm pretty sure it's the cause.

Is there meant to be some magic that I'm missing? I can obviously put some sed magic in my script to do the replacement, but I'd suggest the above getting-started page would need improving to tell users they need to perform the substitution.

Version

22.0.1

Expected behavior

Keycloak up and running

Actual behavior

Got this error:

Events:
  Type     Reason         Age                   From               Message
  ----     ------         ----                  ----               -------
  Normal   Scheduled      17m                   default-scheduler  Successfully assigned default/keycloak-794869df8-trspp to worker-3
  Warning  Failed         15m (x12 over 17m)    kubelet            Error: InvalidImageName
  Warning  InspectFailed  2m51s (x72 over 17m)  kubelet            Failed to apply default image tag "quay.io/keycloak/keycloak:$$VERSION$$": couldn't parse image reference "quay.io/keycloak/keycloak:$$VERSION$$": invalid reference format

How to Reproduce?

Follow instruction on https://www.keycloak.org/getting-started/getting-started-kube

Anything else?

No response

@vmuzikar
Copy link
Contributor

vmuzikar commented Aug 1, 2023

@andreas-ibm Thanks for the report. This indeed seems like a bug.

@goseind
Copy link

goseind commented Aug 18, 2023

I have just encountered the same problem. Would it make sense to use a specific tag again in this manifest, or update the documentation to let users know that they need to change the version tag before applying?

@stianst
Copy link
Contributor

stianst commented Sep 15, 2023

Fixed the script + updated the latest branch to now point to 22.0.3

@andreas-ibm
Copy link
Author

Cool, confirmed fixed

@virtualdxs
Copy link

The script seems to be broken again, as I just hit this issue trying to deploy Keycloak based on the getting started guide.

@vmuzikar
Copy link
Contributor

vmuzikar commented Nov 16, 2023

@virtualdxs Should be fixed in #504, it will be part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants