From 402da1f5f51023637dde6394bef690275d445f18 Mon Sep 17 00:00:00 2001 From: minjo-on Date: Fri, 29 Nov 2024 21:18:34 +0900 Subject: [PATCH 1/5] =?UTF-8?q?refactor:=20=EB=B9=84=EB=B0=80=EB=B2=88?= =?UTF-8?q?=ED=98=B8=20=EA=B2=80=EC=A6=9D=20=EB=A1=9C=EC=A7=81=20=EC=88=98?= =?UTF-8?q?=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../api/auth/application/AuthService.java | 5 +--- .../exception/AuthExceptionCode.java | 24 ------------------- .../exception/InvalidPasswordException.java | 9 ------- .../auth/application/AuthServiceTest.java | 2 +- .../developers/domain/user/domain/User.java | 14 ++++++++--- .../exception/InvalidPasswordException.java | 11 +++++++++ .../exception/UserDomainExceptionCode.java | 6 +++-- 7 files changed, 28 insertions(+), 43 deletions(-) delete mode 100644 aics-api/src/main/java/kgu/developers/api/auth/presentation/exception/AuthExceptionCode.java delete mode 100644 aics-api/src/main/java/kgu/developers/api/auth/presentation/exception/InvalidPasswordException.java create mode 100644 aics-domain/src/main/java/kgu/developers/domain/user/exception/InvalidPasswordException.java diff --git a/aics-api/src/main/java/kgu/developers/api/auth/application/AuthService.java b/aics-api/src/main/java/kgu/developers/api/auth/application/AuthService.java index 6e837ec4..26eaaddc 100644 --- a/aics-api/src/main/java/kgu/developers/api/auth/application/AuthService.java +++ b/aics-api/src/main/java/kgu/developers/api/auth/application/AuthService.java @@ -6,7 +6,6 @@ import org.springframework.stereotype.Service; import org.springframework.transaction.annotation.Transactional; -import kgu.developers.api.auth.presentation.exception.InvalidPasswordException; import kgu.developers.api.auth.presentation.request.LoginRequest; import kgu.developers.api.auth.presentation.response.TokenResponse; import kgu.developers.api.user.application.UserService; @@ -29,9 +28,7 @@ public TokenResponse login(LoginRequest request) { String password = request.password(); User user = userService.getUserById(userId); - if (!passwordEncoder.matches(password, user.getPassword())) { - throw new InvalidPasswordException(); - } + user.isPasswordMatching(password, passwordEncoder); String refreshToken = tokenProvider.generateToken(user.getId(), Duration.ofDays(7)); String accessToken = tokenProvider.generateToken(user.getId(), Duration.ofHours(2)); diff --git a/aics-api/src/main/java/kgu/developers/api/auth/presentation/exception/AuthExceptionCode.java b/aics-api/src/main/java/kgu/developers/api/auth/presentation/exception/AuthExceptionCode.java deleted file mode 100644 index c1f4ee4a..00000000 --- a/aics-api/src/main/java/kgu/developers/api/auth/presentation/exception/AuthExceptionCode.java +++ /dev/null @@ -1,24 +0,0 @@ -package kgu.developers.api.auth.presentation.exception; - -import static org.springframework.http.HttpStatus.BAD_REQUEST; - -import org.springframework.http.HttpStatus; - -import kgu.developers.common.exception.ExceptionCode; -import lombok.AllArgsConstructor; -import lombok.Getter; - -@Getter -@AllArgsConstructor -public enum AuthExceptionCode implements ExceptionCode { - INVALID_PASSWORD(BAD_REQUEST, "비밀번호가 일치하지 않습니다."), - ; - - private final HttpStatus status; - private final String message; - - @Override - public String getCode() { - return this.name(); - } -} \ No newline at end of file diff --git a/aics-api/src/main/java/kgu/developers/api/auth/presentation/exception/InvalidPasswordException.java b/aics-api/src/main/java/kgu/developers/api/auth/presentation/exception/InvalidPasswordException.java deleted file mode 100644 index aa141f87..00000000 --- a/aics-api/src/main/java/kgu/developers/api/auth/presentation/exception/InvalidPasswordException.java +++ /dev/null @@ -1,9 +0,0 @@ -package kgu.developers.api.auth.presentation.exception; - -import kgu.developers.common.exception.CustomException; - -public class InvalidPasswordException extends CustomException { - public InvalidPasswordException() { - super(AuthExceptionCode.INVALID_PASSWORD); - } -} diff --git a/aics-api/src/testFixtures/java/auth/application/AuthServiceTest.java b/aics-api/src/testFixtures/java/auth/application/AuthServiceTest.java index dfbd484f..a6191113 100644 --- a/aics-api/src/testFixtures/java/auth/application/AuthServiceTest.java +++ b/aics-api/src/testFixtures/java/auth/application/AuthServiceTest.java @@ -9,13 +9,13 @@ import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder; import kgu.developers.api.auth.application.AuthService; -import kgu.developers.api.auth.presentation.exception.InvalidPasswordException; import kgu.developers.api.auth.presentation.request.LoginRequest; import kgu.developers.api.user.application.UserService; import kgu.developers.common.auth.jwt.JwtProperties; import kgu.developers.common.auth.jwt.TokenProvider; import kgu.developers.domain.user.domain.Major; import kgu.developers.domain.user.domain.User; +import kgu.developers.domain.user.exception.InvalidPasswordException; import mock.FakeUserRepository; public class AuthServiceTest { diff --git a/aics-domain/src/main/java/kgu/developers/domain/user/domain/User.java b/aics-domain/src/main/java/kgu/developers/domain/user/domain/User.java index 3a01d7f4..afc95318 100644 --- a/aics-domain/src/main/java/kgu/developers/domain/user/domain/User.java +++ b/aics-domain/src/main/java/kgu/developers/domain/user/domain/User.java @@ -11,6 +11,10 @@ import java.util.Collections; import java.util.List; +import org.springframework.security.core.GrantedAuthority; +import org.springframework.security.core.authority.SimpleGrantedAuthority; +import org.springframework.security.core.userdetails.UserDetails; +import org.springframework.security.crypto.password.PasswordEncoder; import jakarta.persistence.Column; import jakarta.persistence.Entity; @@ -22,13 +26,11 @@ import kgu.developers.domain.post.domain.Post; import kgu.developers.domain.user.exception.DeptCodeNotValidException; import kgu.developers.domain.user.exception.EmailDomainNotValidException; +import kgu.developers.domain.user.exception.InvalidPasswordException; import lombok.AllArgsConstructor; import lombok.Builder; import lombok.Getter; import lombok.NoArgsConstructor; -import org.springframework.security.core.GrantedAuthority; -import org.springframework.security.core.authority.SimpleGrantedAuthority; -import org.springframework.security.core.userdetails.UserDetails; @Entity @Getter @@ -126,4 +128,10 @@ private static boolean isValidEmailDomain(String email) { return ACCESSIBLE_EMAIL_DOMAINS.stream() .anyMatch(email::endsWith); } + + public void isPasswordMatching(String rawPassword, PasswordEncoder passwordEncoder) { + if (!passwordEncoder.matches(rawPassword, this.password)) { + throw new InvalidPasswordException(); + } + } } diff --git a/aics-domain/src/main/java/kgu/developers/domain/user/exception/InvalidPasswordException.java b/aics-domain/src/main/java/kgu/developers/domain/user/exception/InvalidPasswordException.java new file mode 100644 index 00000000..43e61f3e --- /dev/null +++ b/aics-domain/src/main/java/kgu/developers/domain/user/exception/InvalidPasswordException.java @@ -0,0 +1,11 @@ +package kgu.developers.domain.user.exception; + +import static kgu.developers.domain.user.exception.UserDomainExceptionCode.INVALID_PASSWORD; + +import kgu.developers.common.exception.CustomException; + +public class InvalidPasswordException extends CustomException { + public InvalidPasswordException() { + super(INVALID_PASSWORD); + } +} diff --git a/aics-domain/src/main/java/kgu/developers/domain/user/exception/UserDomainExceptionCode.java b/aics-domain/src/main/java/kgu/developers/domain/user/exception/UserDomainExceptionCode.java index 6c45efab..40d69523 100644 --- a/aics-domain/src/main/java/kgu/developers/domain/user/exception/UserDomainExceptionCode.java +++ b/aics-domain/src/main/java/kgu/developers/domain/user/exception/UserDomainExceptionCode.java @@ -3,17 +3,19 @@ import static org.springframework.http.HttpStatus.BAD_REQUEST; import static org.springframework.http.HttpStatus.NOT_FOUND; +import org.springframework.http.HttpStatus; + import kgu.developers.common.exception.ExceptionCode; import lombok.AllArgsConstructor; import lombok.Getter; -import org.springframework.http.HttpStatus; @Getter @AllArgsConstructor public enum UserDomainExceptionCode implements ExceptionCode { USER_NOT_FOUND(NOT_FOUND, "해당 회원을 찾을 수 없습니다."), EMAIL_NOT_VALID(BAD_REQUEST, "학교 이메일 형식이 아닙니다."), - DEPT_CODE_NOT_VALID(BAD_REQUEST, "학번별 학과 코드가 일치하지 않습니다.") + DEPT_CODE_NOT_VALID(BAD_REQUEST, "학번별 학과 코드가 일치하지 않습니다."), + INVALID_PASSWORD(BAD_REQUEST, "비밀번호가 일치하지 않습니다."), ; private final HttpStatus status; From 5c907628d43707bcb8a0e466cc1f87c81009a126 Mon Sep 17 00:00:00 2001 From: minjo-on Date: Fri, 29 Nov 2024 21:46:41 +0900 Subject: [PATCH 2/5] =?UTF-8?q?feat:=20=EB=B9=84=EB=B0=80=EB=B2=88?= =?UTF-8?q?=ED=98=B8=20=EA=B2=80=EC=A6=9D=20=ED=85=8C=EC=8A=A4=ED=8A=B8=20?= =?UTF-8?q?=EA=B5=AC=ED=98=84?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../java/user/domain/UserDomainTest.java | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/aics-domain/src/testFixtures/java/user/domain/UserDomainTest.java b/aics-domain/src/testFixtures/java/user/domain/UserDomainTest.java index 32cee9c5..51186b88 100644 --- a/aics-domain/src/testFixtures/java/user/domain/UserDomainTest.java +++ b/aics-domain/src/testFixtures/java/user/domain/UserDomainTest.java @@ -6,12 +6,15 @@ import org.junit.jupiter.api.DisplayName; import org.junit.jupiter.api.Test; +import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder; +import org.springframework.security.crypto.password.PasswordEncoder; import kgu.developers.domain.user.domain.Major; import kgu.developers.domain.user.domain.Role; import kgu.developers.domain.user.domain.User; import kgu.developers.domain.user.exception.DeptCodeNotValidException; import kgu.developers.domain.user.exception.EmailDomainNotValidException; +import kgu.developers.domain.user.exception.InvalidPasswordException; public class UserDomainTest { @@ -75,4 +78,27 @@ public void createUser_InvalidDeptCode_ThrowsException() { User.create(id, password, name, email, phone, major); }).isInstanceOf(DeptCodeNotValidException.class); } + + @Test + @DisplayName("비밀번호가 일치하지 않을 시 InvalidPasswordException이 발생 한다") + public void isPasswordMatching_InvalidPassword_ThrowsException() { + // given + String rawPassword = "invalidPassword"; + PasswordEncoder passwordEncoder = new BCryptPasswordEncoder(); + + User user = User.create( + "202411345", + passwordEncoder.encode("correctPassword"), + "홍길동", + "valid@kgu.ac.kr", + "010-1234-5678", + Major.CSE + ); + + // when + // then + assertThatThrownBy(() -> { + user.isPasswordMatching(rawPassword, passwordEncoder); + }).isInstanceOf(InvalidPasswordException.class); + } } From fa5ca6592ec151c698ddab4dd1cccded4db82f5d Mon Sep 17 00:00:00 2001 From: minjo-on Date: Fri, 29 Nov 2024 21:56:11 +0900 Subject: [PATCH 3/5] =?UTF-8?q?refactor:=20=EC=82=AC=EC=9A=A9=ED=95=98?= =?UTF-8?q?=EC=A7=80=20=EC=95=8A=EB=8A=94=20=EC=97=90=EB=9F=AC=20=EC=BD=94?= =?UTF-8?q?=EB=93=9C=20=EC=A0=9C=EA=B1=B0=20=EB=B0=8F=20=EC=97=90=EB=9F=AC?= =?UTF-8?q?=20=EC=BD=94=EB=93=9C=20=EC=88=98=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../presentation/exception/UserExceptionCode.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/aics-api/src/main/java/kgu/developers/api/user/presentation/exception/UserExceptionCode.java b/aics-api/src/main/java/kgu/developers/api/user/presentation/exception/UserExceptionCode.java index 611be841..d9b37f7f 100644 --- a/aics-api/src/main/java/kgu/developers/api/user/presentation/exception/UserExceptionCode.java +++ b/aics-api/src/main/java/kgu/developers/api/user/presentation/exception/UserExceptionCode.java @@ -1,20 +1,20 @@ package kgu.developers.api.user.presentation.exception; +import static org.springframework.http.HttpStatus.CONFLICT; +import static org.springframework.http.HttpStatus.UNAUTHORIZED; + +import org.springframework.http.HttpStatus; + import kgu.developers.common.exception.ExceptionCode; import lombok.AllArgsConstructor; import lombok.Getter; -import org.springframework.http.HttpStatus; - -import static org.springframework.http.HttpStatus.CONFLICT; -import static org.springframework.http.HttpStatus.FORBIDDEN; @Getter @AllArgsConstructor public enum UserExceptionCode implements ExceptionCode { USER_ID_DUPLICATED(CONFLICT, "이미 동일한 학번으로 가입이 되어있습니다."), USER_EMAIL_ID_DUPLICATED(CONFLICT, "이미 동일한 이메일로 가입이 되어있습니다."), - USER_PHONE_NUMBER_DUPLICATED(CONFLICT, "이미 동일한 전화번호로 가입이 되어있습니다."), - USER_NOT_AUTHENTICATED(FORBIDDEN, "회원 인증에 실패하였습니다."), + USER_NOT_AUTHENTICATED(UNAUTHORIZED, "회원 인증에 실패하였습니다."), ; private final HttpStatus status; From e6956ee303ab3ebfd6d9f81644398be778691753 Mon Sep 17 00:00:00 2001 From: minjo-on Date: Fri, 29 Nov 2024 22:18:41 +0900 Subject: [PATCH 4/5] =?UTF-8?q?refactor:=20=EC=97=90=EB=9F=AC=20=EC=84=A4?= =?UTF-8?q?=EB=AA=85=20=EC=88=98=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../presentation/Exception/AboutExceptionCode.java | 8 ++++---- .../presentation/exception/CommentExceptionCode.java | 9 +++++---- .../file/presentation/exception/FileExceptionCode.java | 10 +++++----- .../lab/presentation/exception/LabExceptionCode.java | 2 +- .../post/presentation/exception/PostExceptionCode.java | 9 +++++---- .../presentation/exception/ProfessorExceptionCode.java | 5 +++-- .../user/presentation/exception/UserExceptionCode.java | 1 - .../exception/UserIdDuplicateException.java | 4 +++- 8 files changed, 26 insertions(+), 22 deletions(-) diff --git a/aics-api/src/main/java/kgu/developers/api/about/presentation/Exception/AboutExceptionCode.java b/aics-api/src/main/java/kgu/developers/api/about/presentation/Exception/AboutExceptionCode.java index c00d8177..89989f7e 100644 --- a/aics-api/src/main/java/kgu/developers/api/about/presentation/Exception/AboutExceptionCode.java +++ b/aics-api/src/main/java/kgu/developers/api/about/presentation/Exception/AboutExceptionCode.java @@ -3,17 +3,17 @@ import static org.springframework.http.HttpStatus.BAD_REQUEST; import static org.springframework.http.HttpStatus.NOT_FOUND; +import org.springframework.http.HttpStatus; + import kgu.developers.common.exception.ExceptionCode; import lombok.AllArgsConstructor; import lombok.Getter; -import org.springframework.http.HttpStatus; @Getter @AllArgsConstructor public enum AboutExceptionCode implements ExceptionCode { - CATEGORY_NOT_MATCH(BAD_REQUEST, "메인 카테고리와 보조 카테고리가 맞지 않습니다."), - ABOUT_NOT_FOUND(NOT_FOUND, "해당 조건의 소개글을 찾을 수 없습니다.") - ; + CATEGORY_NOT_MATCH(BAD_REQUEST, "메인 카테고리와 보조 카테고리가 일치하지 않습니다."), + ABOUT_NOT_FOUND(NOT_FOUND, "해당 소개글을 찾을 수 없습니다."); private final HttpStatus status; private final String message; diff --git a/aics-api/src/main/java/kgu/developers/api/comment/presentation/exception/CommentExceptionCode.java b/aics-api/src/main/java/kgu/developers/api/comment/presentation/exception/CommentExceptionCode.java index dbe56ef0..e2dd0995 100644 --- a/aics-api/src/main/java/kgu/developers/api/comment/presentation/exception/CommentExceptionCode.java +++ b/aics-api/src/main/java/kgu/developers/api/comment/presentation/exception/CommentExceptionCode.java @@ -1,16 +1,17 @@ package kgu.developers.api.comment.presentation.exception; +import static org.springframework.http.HttpStatus.NOT_FOUND; + +import org.springframework.http.HttpStatus; + import kgu.developers.common.exception.ExceptionCode; import lombok.AllArgsConstructor; import lombok.Getter; -import org.springframework.http.HttpStatus; - -import static org.springframework.http.HttpStatus.NOT_FOUND; @Getter @AllArgsConstructor public enum CommentExceptionCode implements ExceptionCode { - COMMENT_NOT_FOUND(NOT_FOUND, "해당 ID의 댓글이 없습니다."); + COMMENT_NOT_FOUND(NOT_FOUND, "해당 댓글을 찾을 수 없습니다."); private final HttpStatus status; private final String message; diff --git a/aics-api/src/main/java/kgu/developers/api/file/presentation/exception/FileExceptionCode.java b/aics-api/src/main/java/kgu/developers/api/file/presentation/exception/FileExceptionCode.java index 4354897b..5dfd8e64 100644 --- a/aics-api/src/main/java/kgu/developers/api/file/presentation/exception/FileExceptionCode.java +++ b/aics-api/src/main/java/kgu/developers/api/file/presentation/exception/FileExceptionCode.java @@ -1,17 +1,17 @@ package kgu.developers.api.file.presentation.exception; +import static org.springframework.http.HttpStatus.BAD_REQUEST; + +import org.springframework.http.HttpStatus; + import kgu.developers.common.exception.ExceptionCode; import lombok.AllArgsConstructor; import lombok.Getter; -import org.springframework.http.HttpStatus; - -import static org.springframework.http.HttpStatus.*; @Getter @AllArgsConstructor public enum FileExceptionCode implements ExceptionCode { - FILE_SAVING_ERROR(BAD_REQUEST, "파일 저장이 되지 않았습니다.") - ; + FILE_SAVING_ERROR(BAD_REQUEST, "파일 저장에 실패하였습니다."); private final HttpStatus status; private final String message; diff --git a/aics-api/src/main/java/kgu/developers/api/lab/presentation/exception/LabExceptionCode.java b/aics-api/src/main/java/kgu/developers/api/lab/presentation/exception/LabExceptionCode.java index 1ae7f7ce..6ae8e4ba 100644 --- a/aics-api/src/main/java/kgu/developers/api/lab/presentation/exception/LabExceptionCode.java +++ b/aics-api/src/main/java/kgu/developers/api/lab/presentation/exception/LabExceptionCode.java @@ -11,7 +11,7 @@ @Getter @AllArgsConstructor public enum LabExceptionCode implements ExceptionCode { - LAB_NOT_FOUND(NOT_FOUND, "해당 ID의 연구실이 없습니다."); + LAB_NOT_FOUND(NOT_FOUND, "해당 연구실을 찾을 수 없습니다."); private final HttpStatus status; private final String message; diff --git a/aics-api/src/main/java/kgu/developers/api/post/presentation/exception/PostExceptionCode.java b/aics-api/src/main/java/kgu/developers/api/post/presentation/exception/PostExceptionCode.java index 4f86c2a3..079ca25f 100644 --- a/aics-api/src/main/java/kgu/developers/api/post/presentation/exception/PostExceptionCode.java +++ b/aics-api/src/main/java/kgu/developers/api/post/presentation/exception/PostExceptionCode.java @@ -1,16 +1,17 @@ package kgu.developers.api.post.presentation.exception; +import static org.springframework.http.HttpStatus.NOT_FOUND; + +import org.springframework.http.HttpStatus; + import kgu.developers.common.exception.ExceptionCode; import lombok.AllArgsConstructor; import lombok.Getter; -import org.springframework.http.HttpStatus; - -import static org.springframework.http.HttpStatus.NOT_FOUND; @Getter @AllArgsConstructor public enum PostExceptionCode implements ExceptionCode { - POST_NOT_FOUND(NOT_FOUND, "해당 ID의 게시글이 없습니다."); + POST_NOT_FOUND(NOT_FOUND, "해당 게시글을 찾을 수 없습니다."); private final HttpStatus status; private final String message; diff --git a/aics-api/src/main/java/kgu/developers/api/professor/presentation/exception/ProfessorExceptionCode.java b/aics-api/src/main/java/kgu/developers/api/professor/presentation/exception/ProfessorExceptionCode.java index 2dc55495..0be963e7 100644 --- a/aics-api/src/main/java/kgu/developers/api/professor/presentation/exception/ProfessorExceptionCode.java +++ b/aics-api/src/main/java/kgu/developers/api/professor/presentation/exception/ProfessorExceptionCode.java @@ -2,15 +2,16 @@ import static org.springframework.http.HttpStatus.NOT_FOUND; +import org.springframework.http.HttpStatus; + import kgu.developers.common.exception.ExceptionCode; import lombok.AllArgsConstructor; import lombok.Getter; -import org.springframework.http.HttpStatus; @Getter @AllArgsConstructor public enum ProfessorExceptionCode implements ExceptionCode { - PROFESSOR_NOT_FOUND(NOT_FOUND, "해당 ID의 교수가 없습니다."); + PROFESSOR_NOT_FOUND(NOT_FOUND, "해당 교수를 찾을 수 없습니다."); private final HttpStatus status; private final String message; diff --git a/aics-api/src/main/java/kgu/developers/api/user/presentation/exception/UserExceptionCode.java b/aics-api/src/main/java/kgu/developers/api/user/presentation/exception/UserExceptionCode.java index d9b37f7f..71dd7c68 100644 --- a/aics-api/src/main/java/kgu/developers/api/user/presentation/exception/UserExceptionCode.java +++ b/aics-api/src/main/java/kgu/developers/api/user/presentation/exception/UserExceptionCode.java @@ -13,7 +13,6 @@ @AllArgsConstructor public enum UserExceptionCode implements ExceptionCode { USER_ID_DUPLICATED(CONFLICT, "이미 동일한 학번으로 가입이 되어있습니다."), - USER_EMAIL_ID_DUPLICATED(CONFLICT, "이미 동일한 이메일로 가입이 되어있습니다."), USER_NOT_AUTHENTICATED(UNAUTHORIZED, "회원 인증에 실패하였습니다."), ; diff --git a/aics-api/src/main/java/kgu/developers/api/user/presentation/exception/UserIdDuplicateException.java b/aics-api/src/main/java/kgu/developers/api/user/presentation/exception/UserIdDuplicateException.java index 8b7f9151..3971cb1f 100644 --- a/aics-api/src/main/java/kgu/developers/api/user/presentation/exception/UserIdDuplicateException.java +++ b/aics-api/src/main/java/kgu/developers/api/user/presentation/exception/UserIdDuplicateException.java @@ -1,9 +1,11 @@ package kgu.developers.api.user.presentation.exception; +import static kgu.developers.api.user.presentation.exception.UserExceptionCode.USER_ID_DUPLICATED; + import kgu.developers.common.exception.CustomException; public class UserIdDuplicateException extends CustomException { public UserIdDuplicateException() { - super(UserExceptionCode.USER_ID_DUPLICATED); + super(USER_ID_DUPLICATED); } } From e84162f1f3ac5f949d50f4dcaa187a340daace1c Mon Sep 17 00:00:00 2001 From: minjo-on Date: Sat, 30 Nov 2024 00:27:14 +0900 Subject: [PATCH 5/5] =?UTF-8?q?refactor:=20=EC=84=B8=EB=AF=B8=EC=BD=9C?= =?UTF-8?q?=EB=A1=A0=20=EA=B0=9C=ED=96=89=20=EC=B6=94=EA=B0=80?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../api/about/presentation/Exception/AboutExceptionCode.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/aics-api/src/main/java/kgu/developers/api/about/presentation/Exception/AboutExceptionCode.java b/aics-api/src/main/java/kgu/developers/api/about/presentation/Exception/AboutExceptionCode.java index 89989f7e..87e3328e 100644 --- a/aics-api/src/main/java/kgu/developers/api/about/presentation/Exception/AboutExceptionCode.java +++ b/aics-api/src/main/java/kgu/developers/api/about/presentation/Exception/AboutExceptionCode.java @@ -13,7 +13,8 @@ @AllArgsConstructor public enum AboutExceptionCode implements ExceptionCode { CATEGORY_NOT_MATCH(BAD_REQUEST, "메인 카테고리와 보조 카테고리가 일치하지 않습니다."), - ABOUT_NOT_FOUND(NOT_FOUND, "해당 소개글을 찾을 수 없습니다."); + ABOUT_NOT_FOUND(NOT_FOUND, "해당 소개글을 찾을 수 없습니다."), + ; private final HttpStatus status; private final String message;