Skip to content

Commit 30cb743

Browse files
committed
fixes UX issue: links are underlined by default
1 parent 3bc48c0 commit 30cb743

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

app/Resources/views/base.html.twig

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,10 @@
5555
</ul>
5656
</section>
5757
</nav>
58+
59+
<section role="main" id="main">
5860
{% block body %}{% endblock %}
61+
</section>
5962

6063
<footer class="full-width">
6164
<div class="row">

src/Legislator/LegislatorBundle/Resources/public/css/app.css

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@ dl.document-data dt {float: left; clear: left; min-width: 7em;}
2121
dl.document-data dt:after {content: ":";}
2222
dl.document-data dd {margin-bottom: 0.4em;}
2323

24-
a:hover {text-decoration: underline;}
25-
a.button:hover {text-decoration: none;}
24+
#main a:link {text-decoration: underline;}
25+
#main a:hover {text-decoration: none;}
26+
#main a.button {text-decoration: none;}
2627

2728
#org-unit {font-weight: normal;}
2829

src/Legislator/LegislatorBundle/Tests/Controller/DocumentControllerTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,10 @@ public function testCommentUntilDate()
9090
$this->assertTrue($this->client->getResponse()->isSuccessful());
9191

9292
// check the change
93-
$this->assertTrue($crawler->filterXPath('//body/div[3]/div/h2/time')->text() == "15. 01. 2014");
93+
$this->assertTrue($crawler->filterXPath('//body/*[@id="main"]/div[3]/div/h2/time')->text() == "15. 01. 2014");
9494
$crawler = $this->client->request('GET', $this->getUrl('legislator_homepage'));
9595
$this->assertTrue($this->client->getResponse()->isSuccessful());
96-
$this->assertTrue($crawler->filterXPath('//body/div[1]/div/table/tbody/tr[1]/td[8]/time')->text() == "15. 01. 2014");
96+
$this->assertTrue($crawler->filterXPath('//body/*[@id="main"]/div[1]/div/table/tbody/tr[1]/td[8]/time')->text() == "15. 01. 2014");
9797
}
9898

9999
public function testDelete()

0 commit comments

Comments
 (0)