Fix Codacy errors

Author: matthias-ronge

Kitodo/src/main/java/org/kitodo/production/forms/dataeditor/GalleryPanel.java

@@ -37,8 +37,8 @@
 import org.apache.logging.log4j.Logger;
 import org.kitodo.api.dataeditor.rulesetmanagement.RulesetManagementInterface;
 import org.kitodo.api.dataformat.LogicalDivision;
-import org.kitodo.api.dataformat.PhysicalDivision;
 import org.kitodo.api.dataformat.MediaVariant;
+import org.kitodo.api.dataformat.PhysicalDivision;
 import org.kitodo.api.dataformat.View;
 import org.kitodo.data.database.beans.Folder;
 import org.kitodo.data.database.beans.Process;
@@ -528,15 +528,20 @@ public GalleryMediaContent getGalleryMediaContent(PhysicalDivision physicalDivis
     }
 
     /**
-     * Get a List of all PhysicalDivisions and the LogicalDivisions they are assigned to
-     * which are displayed between two selected PhysicalDivisions. This method selects the Stripes that are affected by the selection and delegates
-     * the selection of the contained PhysicalDivisions.
+     * Get a List of all PhysicalDivisions and the LogicalDivisions they are
+     * assigned to which are displayed between two selected PhysicalDivisions.
+     * This method selects the Stripes that are affected by the selection and
+     * delegates the selection of the contained PhysicalDivisions.
+     *
      * @param first
-     *          First selected PhysicalDivision. A Pair of the PhysicalDivision and the LogicalDivision to which the PhysicalDivision is assigned.
+     *            First selected PhysicalDivision. A Pair of the
+     *            PhysicalDivision and the LogicalDivision to which the
+     *            PhysicalDivision is assigned.
      * @param last
-     *          Last selected PhysicalDivision. A Pair of the PhysicalDivision and the Logical Division to which the PhysicalDivision is assigned.
-     * @return
-     *          A List of all selected PhysicalDivisions
+     *            Last selected PhysicalDivision. A Pair of the PhysicalDivision
+     *            and the Logical Division to which the PhysicalDivision is
+     *            assigned.
+     * @return A List of all selected PhysicalDivisions
      */
     private List<Pair<PhysicalDivision, LogicalDivision>> getMediaWithinRange(Pair<PhysicalDivision, LogicalDivision> first,
                                                           Pair<PhysicalDivision, LogicalDivision> last) {
@@ -582,18 +587,23 @@ This stripe is displayed last, but is actually the logical structure (first stri
     }
 
     /**
-     * Get a List of all PhysicalDivisions and the LogicalDivisions they are assigned to
-     * which are displayed between two selected PhysicalDivisions. This method selected the PhysicalDivisions between and including the two indices.
+     * Get a List of all PhysicalDivisions and the LogicalDivisions they are
+     * assigned to which are displayed between two selected PhysicalDivisions.
+     * This method selected the PhysicalDivisions between and including the two
+     * indices.
+     *
      * @param firstIndices
-     *          First selected PhysicalDivision.
-     *          A Pair of indices of the PhysicalDivision and the LogicalDivision to which the PhysicalDivision is assigned.
+     *            First selected PhysicalDivision. A Pair of indices of the
+     *            PhysicalDivision and the LogicalDivision to which the
+     *            PhysicalDivision is assigned.
      * @param lastIndices
-     *          Last selected PhysicalDivision.
-     *          A Pair of indices of the PhysicalDivision and the Logical Division to which the PhysicalDivision is assigned.
+     *            Last selected PhysicalDivision. A Pair of indices of the
+     *            PhysicalDivision and the Logical Division to which the
+     *            PhysicalDivision is assigned.
      * @param galleryStripes
-     *          A List of GalleryStripes which contain the two selected PhysicalDivisions and all in between
-     * @return
-     *          A List of all selected PhysicalDivisions
+     *            A List of GalleryStripes which contain the two selected
+     *            PhysicalDivisions and all in between
+     * @return A List of all selected PhysicalDivisions
      */
     private List<Pair<PhysicalDivision, LogicalDivision>> getMediaWithinRangeFromSelectedStripes(
             Pair<Integer, Integer> firstIndices, Pair<Integer, Integer> lastIndices, List<GalleryStripe> galleryStripes) {
@@ -720,7 +730,8 @@ public boolean isSelected(GalleryMediaContent galleryMediaContent, GalleryStripe
 
     private void selectMedia(String physicalDivisionOrder, String stripeIndex, String selectionType) {
         PhysicalDivision selectedPhysicalDivision = null;
-        for (PhysicalDivision physicalDivision : this.dataEditor.getWorkpiece().getAllPhysicalDivisionChildrenFilteredByTypePageAndSorted()) {
+        for (PhysicalDivision physicalDivision : this.dataEditor.getWorkpiece()
+                .getAllPhysicalDivisionChildrenFilteredByTypePageAndSorted()) {
             if (Objects.equals(physicalDivision.getOrder(), Integer.parseInt(physicalDivisionOrder))) {
                 selectedPhysicalDivision = physicalDivision;
                 break;
@@ -832,7 +843,8 @@ private void defaultSelect(GalleryMediaContent currentSelection, GalleryStripe p
         }
 
         dataEditor.getSelectedMedia().clear();
-        dataEditor.getSelectedMedia().add(new ImmutablePair<>(currentSelection.getView().getPhysicalDivision(), parentStripe.getStructure()));
+        dataEditor.getSelectedMedia().add(
+            new ImmutablePair<>(currentSelection.getView().getPhysicalDivision(), parentStripe.getStructure()));
     }
 
     private void rangeSelect(GalleryMediaContent currentSelection, GalleryStripe parentStripe) {
@@ -867,11 +879,14 @@ private void multiSelect(GalleryMediaContent currentSelection, GalleryStripe par
     }
 
     /**
-     * Get the index of this GalleryMediaContent's PhysicalDivision out of all PhysicalDivisions
-     * which are assigned to more than one LogicalDivision.
+     * Get the index of this GalleryMediaContent's PhysicalDivision out of all
+     * PhysicalDivisions which are assigned to more than one LogicalDivision.
      *
-     * @param galleryMediaContent object to find the index for
-     * @return index of the GalleryMediaContent's PhysicalDivision if present in the List of several assignments, or -1 if not present in the list.
+     * @param galleryMediaContent
+     *            object to find the index for
+     * @return index of the GalleryMediaContent's PhysicalDivision if present in
+     *         the List of several assignments, or -1 if not present in the
+     *         list.
      */
     public int getSeveralAssignmentsIndex(GalleryMediaContent galleryMediaContent) {
         if (Objects.nonNull(galleryMediaContent.getView()) && Objects.nonNull(galleryMediaContent.getView().getPhysicalDivision())) {

Kitodo/src/main/java/org/kitodo/production/forms/dataeditor/StructurePanel.java

@@ -874,7 +874,8 @@ private TreeNode updatePhysSelectionInLogTreeRecursive(PhysicalDivision selected
                     && ((StructureTreeNode) treeNode.getData()).getDataObject().equals(parentElement)
                     && currentTreeNode.getData() instanceof StructureTreeNode
                     && ((StructureTreeNode) currentTreeNode.getData()).getDataObject() instanceof View
-                    && ((View) ((StructureTreeNode) currentTreeNode.getData()).getDataObject()).getPhysicalDivision().equals(selectedPhysicalDivision)) {
+                    && ((View) ((StructureTreeNode) currentTreeNode.getData()).getDataObject()).getPhysicalDivision()
+                            .equals(selectedPhysicalDivision)) {
                 currentTreeNode.setSelected(true);
                 matchingTreeNode = currentTreeNode;
             } else {
@@ -1472,11 +1473,14 @@ public void setActiveTabs(String activeTabs) {
     }
 
     /**
-     * Get the index of this StructureTreeNode's PhysicalDivision out of all PhysicalDivisions
-     * which are assigned to more than one LogicalDivision.
+     * Get the index of this StructureTreeNode's PhysicalDivision out of all
+     * PhysicalDivisions which are assigned to more than one LogicalDivision.
      *
-     * @param treeNode object to find the index for
-     * @return index of the StructureTreeNode's PhysicalDivision if present in the List of several assignments, or -1 if not present in the list.
+     * @param treeNode
+     *            object to find the index for
+     * @return index of the StructureTreeNode's PhysicalDivision if present in
+     *         the List of several assignments, or -1 if not present in the
+     *         list.
      */
     public int getMultipleAssignmentsIndex(StructureTreeNode treeNode) {
         if (treeNode.getDataObject() instanceof View

Kitodo/src/main/java/org/kitodo/production/metadata/MetadataEditor.java

@@ -298,13 +298,15 @@ public static LogicalDivision addLogicalDivision(String type, Workpiece workpiec
      * @param parent parent of the new PhysicalDivision
      * @param position position relative to the parent element
      */
-    public static PhysicalDivision addPhysicalDivision(String type, Workpiece workpiece, PhysicalDivision parent, InsertionPosition position) {
+    public static PhysicalDivision addPhysicalDivision(String type, Workpiece workpiece, PhysicalDivision parent,
+            InsertionPosition position) {
         LinkedList<PhysicalDivision> grandparents = getAncestorsOfPhysicalDivision(parent, workpiece.getPhysicalStructure());
         List<PhysicalDivision> siblings = new LinkedList<>();
         if (grandparents.isEmpty()) {
             if (position.equals(InsertionPosition.AFTER_CURRENT_ELEMENT)
                     || position.equals(InsertionPosition.BEFORE_CURRENT_ELEMENT)) {
-                Helper.setErrorMessage("No parent found for currently selected physical division to which new physical division can be appended!");
+                Helper.setErrorMessage("No parent found for currently selected physical "
+                        + "division to which new physical division can be appended!");
             }
         } else {
             siblings = grandparents.getLast().getChildren();

Kitodo/src/main/java/org/kitodo/production/services/file/FileService.java

@@ -38,8 +38,8 @@
 import org.apache.logging.log4j.Logger;
 import org.kitodo.api.command.CommandResult;
 import org.kitodo.api.dataformat.LogicalDivision;
-import org.kitodo.api.dataformat.PhysicalDivision;
 import org.kitodo.api.dataformat.MediaVariant;
+import org.kitodo.api.dataformat.PhysicalDivision;
 import org.kitodo.api.dataformat.View;
 import org.kitodo.api.dataformat.Workpiece;
 import org.kitodo.api.filemanagement.FileManagementInterface;
@@ -1087,7 +1087,8 @@ public void searchForMedia(Process process, Workpiece workpiece) throws InvalidI
         }
         List<String> canonicals = getCanonicalFileNamePartsAndSanitizeAbsoluteURIs(workpiece, subfolders,
             process.getProcessBaseUri());
-        addNewURIsToExistingPhysicalDivisions(mediaToAdd, workpiece.getAllPhysicalDivisionChildrenFilteredByTypePageAndSorted(), canonicals);
+        addNewURIsToExistingPhysicalDivisions(mediaToAdd,
+            workpiece.getAllPhysicalDivisionChildrenFilteredByTypePageAndSorted(), canonicals);
         mediaToAdd.keySet().removeAll(canonicals);
         addNewMediaToWorkpiece(canonicals, mediaToAdd, workpiece);
         renumberPhysicalDivisions(workpiece, true);
@@ -1161,8 +1162,8 @@ private List<String> getCanonicalFileNamePartsAndSanitizeAbsoluteURIs(Workpiece
     /**
      * Adds new media variants found to existing physical divisions.
      */
-    private void addNewURIsToExistingPhysicalDivisions(Map<String, Map<Subfolder, URI>> mediaToAdd, List<PhysicalDivision> physicalDivisions,
-            List<String> canonicals) {
+    private void addNewURIsToExistingPhysicalDivisions(Map<String, Map<Subfolder, URI>> mediaToAdd,
+            List<PhysicalDivision> physicalDivisions, List<String> canonicals) {
 
         for (int i = 0; i < canonicals.size(); i++) {
             String canonical = canonicals.get(i);