Actions from dropdown are executed for all processes instead of selected ones

[IkramMaalej]

Describe the bug
Not all actions are executed only for the selected processes. Some actions are executed for all processes instead of only the selected ones.

To Reproduce
Steps to reproduce the behavior:

1. Go to Processes
2. Select multiple specific processes
3. Open the Actions dropdown menu
4. Execute an action (e.g. create PDF, etc.)
5. Observe that the action is executed for all processes instead of only the selected ones.

Expected behavior
The selected action should only be executed for the processes that were explicitly selected via the checkbox.

Screenshots
If applicable, add screenshots to help explain your problem.

Release
Kitodo.Production Version: 4.0.0-SNAPSHOT

[solth]

There is a function in ProcessListBaseView.java to check whether all processes are selected:

kitodo-production/Kitodo/src/main/java/org/kitodo/production/forms/ProcessListBaseView.java

Line 114 in 26e6b70

public boolean isAllSelected() {

But apparently this method is never used. Maybe that is related to the issue reported here?

[BartChris]

For which specific functions is this happening: Excel, PDF, CSV ... something else?
If we talk about those (Excel, PDF, CSV) specifically: What behaviour is desired if nothing is selected? Do we want to force people to use "Select all processes" if they want to export the complete list (which might contain 100.000 entries and more)?

[solth]

Do we want to force people to use "Select all processes" if they want to export the complete list (which might contain 100.000 entries and more)?

The way it is currently implemented checking the 'All processes' checkbox does not actually fill a huge list of selected processes manually, but instead a single flag for "all processes" is set, IIRC. So selecting "All processes" wouldn't be asking a lot of the users or stress the system resources too much, I think (perhaps @IkramMaalej can confirm this?)

[BartChris]

I see. I am however sceptical as i think the "selected" Processes are right now modeled as entities: I fear that we have to bring them all into memory the moment we press "export" to check what gets exported. So it should definitely be checked what the consequences are.

Edit: Maybe it is possible to use the excludedIds as negative filter in the SQL query, when all records are selected.

[solth]

I see. I am however sceptical as i think the "selected" Processes are right now modeled as entities: I fear that we have to bring them all into memory the moment we press "export" to check what gets exported. So it should definitely be checked what the consequences are.

I get your point, actually loading all processes into memory could be problematic. But that also depends on the actual list action performed, I think, as they may be implemented differently.

Anyway, I consider this a critical bug, since right now an action could be performed on the entire list of all processes, even though - visually - only a handful on the first page are selected. No matter how this is resolved, it has to resolved for the next release, IMHO.

Edit: Maybe it is possible to use the excludedIds as negative filter in the SQL query, when all records are selected.

That sounds like a good idea.

[henning-gerhardt]

Should be not first be discussed which available action and use scenario should only work on limited / selected processes and which should work on all hits by default? Creating process status through excel / csv / pdf lists would make it more complicated if you must select first all hits which could be ten thousand and more processes. On the other side: exporting more than one thousand newspaper like processes at once is resource intensive issue (at least at SLUB) where you more acting with already limited process id lists.

pinging @kitodo/kitodo-community-board for first possible discussion than creating "solutions" which may not fit in the usage scenarios