Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream#master into kitsteam/excalidraw#master #6

Merged
merged 10 commits into from
Sep 4, 2024

Conversation

sorenjohanson
Copy link

No description provided.

@JannikStreek
Copy link
Member

thanks, looks pretty good so far, sharing etc works, colors seem to be also fine. However, apparently excalidraw introduced some non translated menu fields. In addition, there are quite a few references to excalidraw plus. We need to fix these language translations and remove links to excalidraw plus.

Bildschirmfoto 2024-09-03 um 15 02 59 Bildschirmfoto 2024-09-03 um 15 02 49 Bildschirmfoto 2024-09-03 um 15 02 44 Bildschirmfoto 2024-09-03 um 15 02 35 Bildschirmfoto 2024-09-03 um 15 02 19 Bildschirmfoto 2024-09-03 um 14 59 39

@sorenjohanson
Copy link
Author

Regarding "Replace my content": It's translated, but there's a bug in excalidraw/excalidraw where translations aren't applied correctly to a newly opened modal. Only way to get the translations to apply is by changing them in excalidraw-app/App.tsx on the spot, at which point they work as long as the modal is open.

@JannikStreek
Copy link
Member

Regarding "Replace my content": It's translated, but there's a bug in excalidraw/excalidraw where translations aren't applied correctly to a newly opened modal. Only way to get the translations to apply is by changing them in excalidraw-app/App.tsx on the spot, at which point they work as long as the modal is open.

As we only have a German audience, it's also fine for me if we e.g. hardcode the German translations as long as this bug persists. Or any other strategy you find valid.

@JannikStreek JannikStreek merged commit 4a48214 into kitsteam:master Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants