Merge pull request #129 from astorije/astorije/node-4

Use strict mode everywhere to make sure Node v4 is compatible with ES6 features

Author: Max Leiter

browser.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * The default irc-framework interface for browsers
  * Usage: var IrcFramework = require('irc-framework/browser');

index.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * The default irc-framework interface for nodejs
  * Usage: var IrcFramework = require('irc-framework');

src/channel.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var _ = require('lodash');
 var DuplexStream = require('stream').Duplex;
 

src/client.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var EventEmitter = require('eventemitter3');
 var _ = require('lodash');
 var MiddlewareHandler = require('middleware-handler');

src/commands/command.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var _ = require('lodash');
 
 module.exports = IrcCommand;

src/commands/handler.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var _ = require('lodash');
 var EventEmitter = require('eventemitter3');
 var irc_numerics = require('./numerics');

src/commands/handlers/channel.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var _ = require('lodash');
 var Helpers = require('../../helpers');
 

src/commands/handlers/generics.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /*
 
 Generic IRC events. Simply passing selected IRC params into javascript objects

src/commands/handlers/messaging.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var _ = require('lodash');
 var util = require('util');
 

src/commands/handlers/misc.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var _ = require('lodash');
 
 var handlers = {
@@ -204,7 +206,7 @@ module.exports = function AddCommandHandlers(command_controller) {
 function getChanListCache(that) {
     var cache = that.cache('chanlist');
 
-    // fix some IRC networks 
+    // fix some IRC networks
     if (!cache.channels) {
         cache.channels = [];
     }

src/commands/handlers/registration.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var _ = require('lodash');
 
 var handlers = {

src/commands/handlers/user.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var _ = require('lodash');
 
 var handlers = {

src/commands/index.js

@@ -1,2 +1,4 @@
+'use strict';
+
 module.exports.Command = require('./command');
 module.exports.CommandHandler = require('./handler');

src/commands/numerics.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = {
     '001': 'RPL_WELCOME',
     '002': 'RPL_YOURHOST',

src/connection.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var EventEmitter    = require('eventemitter3');
 var _               = require('lodash');
 var ircLineParser   = require('./irclineparser');
@@ -174,27 +176,27 @@ Connection.prototype.setTimeout = function(/*fn, length, argN */) {
     var tmr = null;
     var args = Array.prototype.slice.call(arguments, 0);
     var callback = args[0];
-    
+
     args[0] = function() {
        _.pull(that._timers, tmr);
        callback.apply(null, args);
     };
-    
+
     tmr = setTimeout.apply(null, args);
     this._timers.push(tmr);
     return tmr;
 };
 
 Connection.prototype.clearTimeout = function(tmr) {
 	clearTimeout(tmr);
-	_.pull(this._timers, tmr); 
+	_.pull(this._timers, tmr);
 };
 
 Connection.prototype.clearTimers = function() {
     this._timers.forEach(function(tmr) {
         clearTimeout(tmr);
     });
-    
+
     this._timers = [];
 };
 

src/irclineparser.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var _ = require('lodash');
 
 module.exports = parseIrcLine;

src/networkinfo.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = NetworkInfo;
 
 function NetworkInfo() {

src/transports/net.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * TCP / TLS transport
  */

src/transports/websocket.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Websocket transport
  */

src/user.js

@@ -1,3 +1,5 @@
+'use strict';
+
 function User(opts) {
     opts = opts || {};
 

test/commands/handlers/misc.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /*globals describe, it */
 /* jshint -W024 */
 /* jshint expr:true */

test/helper.test.js

@@ -1,4 +1,5 @@
-"use strict";
+'use strict';
+
 /*globals describe, it */
 let chai = require('chai'),
     Helper = require('../src/helpers'),

test/ircLineParser.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /*globals describe, it */
 var chai = require('chai'),
     parseIrcLine = require('../src/irclineparser'),
@@ -111,7 +113,7 @@ describe('src/irclineparser.js', function () {
                 command: 'TEST'
             });
         });
-        
+
 
         it('should parse a command with a single parameter and a nick@hostname prefix', function () {
             var msgObj = parseIrcLine(':nick@example.org TEST foo');
@@ -279,7 +281,7 @@ describe('src/irclineparser.js', function () {
                 command: 'TEST'
             });
         });
-        
+
         it('should parse a message that has a tag with a value', function () {
             var msgObj = parseIrcLine('@foo=bar TEST');
 
@@ -339,7 +341,7 @@ describe('src/irclineparser.js', function () {
                 hostname: 'example.org'
             });
         });
-        
+
         it('should parse a message that has a tag with no value and a nick!ident@hostname prefix', function () {
             var msgObj = parseIrcLine('@foo :nick!ident@example.org TEST');
 
@@ -650,7 +652,7 @@ describe('src/irclineparser.js', function () {
                 params: ['bar', 'baz']
             });
         });
-        
+
         it('should parse a message that has a tag with no value, a "trailing" parameter that has spaces and a nick@hostname prefix', function () {
             var msgObj = parseIrcLine('@foo :nick@example.org TEST :hello world');
 
@@ -754,7 +756,7 @@ describe('src/irclineparser.js', function () {
                 params: ['bar', 'baz']
             });
         });
-        
+
         it('should parse a message that has a tag with no value, a "trailing" parameter that has spaces and a nick!ident@hostname prefix', function () {
             var msgObj = parseIrcLine('@foo :nick!ident@example.org TEST :hello world');
 
@@ -1047,7 +1049,7 @@ describe('src/irclineparser.js', function () {
                 params: ['bar', 'baz']
             });
         });
-        
+
         it('should parse a message that has a tag with a value, a "trailing" parameter that has spaces and a nick!ident@hostname prefix', function () {
             var msgObj = parseIrcLine('@foo=testvalue :nick!ident@example.org TEST :hello world');
 
@@ -1360,7 +1362,7 @@ describe('src/irclineparser.js', function () {
                 params: ['bar', 'baz']
             });
         });
-        
+
         it('should parse a message that has multiple tags with no values, a "trailing" parameter that has spaces and a nick!ident@hostname prefix', function () {
             var msgObj = parseIrcLine('@foo;bar :nick!ident@example.org TEST :hello world');
 
@@ -1564,7 +1566,7 @@ describe('src/irclineparser.js', function () {
                 params: ['bar', 'baz']
             });
         });
-        
+
         it('should parse a message that has multiple tags one with a value, a "trailing" parameter that has spaces and a nick@hostname prefix', function () {
             var msgObj = parseIrcLine('@foo=bar;baz :nick@example.org TEST :hello world');
 
@@ -1675,7 +1677,7 @@ describe('src/irclineparser.js', function () {
                 params: ['bar', 'baz']
             });
         });
-        
+
         it('should parse a message that has multiple tags one with a value, a "trailing" parameter that has spaces and a nick!ident@hostname prefix', function () {
             var msgObj = parseIrcLine('@foo=bar;baz :nick!ident@example.org TEST :hello world');
 

test/mocks.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var sinon = require('sinon'),
     _ = require('lodash');