Consider factory methods for PortAssignment and PortSecurity enums

[sleberknight]

We have configuration classes with boolean properties like useDynamicPorts and useSecurePorts. When creating PortAssigner instances we need to convert these values into the PortAssignment and PortSecurity enum values, requiring code like:

var portAssigner = PortAssigner.builder()
    .portAssignment(config.isUseDynamicPorts() ? PortAssignment.DYNAMIC : PortAssignment.STATIC)
    .portSecurity(config.isUseSecurePorts() ? PortSecurity.SECURE : PortSecurity.NON_SECURE)
    .allowablePortRange(new AllowablePortRange(config.getMinPort(), config.getMaxPort()))
    .serverFactory(config.getServerFactory())
    .build();

The ternary expressions are not the prettiest. You could also use an if/elsebut that's not great either. It might be a little nicer to write code such as this:

var portAssigner = PortAssigner.builder()
    .portAssignment(PortAssignment.forDynamicPorts(config.isUseDynamicPorts()))
    .portSecurity(PortSecurity.forSecurePorts(config.isUseSecurePorts()))
    .allowablePortRange(new AllowablePortRange(config.getMinPort(), config.getMaxPort()))
    .serverFactory(config.getServerFactory())
    .build();

The implementations for the above are simple:

public enum PortAssignment {
    STATIC, DYNAMIC;

    public static PortAssignment forDynamicPorts(boolean useDynamicPorts) {
        return useDynamicPorts ? DYNAMIC : STATIC;
    }
}

public enum PortSecurity {
    SECURE, NON_SECURE;

    public static PortSecurity forSecurePorts(boolean useSecurePorts) {
        return useSecurePorts ? SECURE : NON_SECURE;
    }
}

Because I'm not sure I like the above naming (forDynamicPorts and forSecurePorts) here are a few alternative names for the PortAssignment enum (I asked ChatGPT for some suggestions):

• fromBoolean
• assignDynamicIfTrue
• booleanToPortAssignment
• getPortAssignmentByFlag
• dynamicForTrue

These are somewhat OK, though the ultra-generic ones fromBoolean and booleanToPortAssignment don't help a reader determine what the return value will be. And getPortAssignmentByFlag makes little sense. But, assignDynamicIfTrue and dynamicForTrue aren't bad, and more clearly convey the intent than my original one (forDynamicPorts). So, perhaps one of those or a variant such as dynamicIfTrue or dynamicWhenTrue instead of dynamicForTrue.

Similarly, for PortSecurity, secureForTrue, secureIfTrue, secureWhenTrue, or assignSecureIfTrue all are more clear than forSecurePorts).

[sleberknight]

Fixed by #463 , #464, and #465