Skip to content

Scoring 2 sets with 1 puck slide will cause the first set animation to be incorrect #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
klapstoelpiloot opened this issue Mar 17, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@klapstoelpiloot
Copy link
Owner

When 1 puck slide is used to score 2 sets (2 pucks enter gates which each finish a set), then the set animation will show twice. However, the first animation is for the same set index as the second animation.

This bug is caused due to the set index to animate is set directly on the setanimation object in the PlayingState (line 249), but the actual animation is queued to be displayed at a later time. This bug does not cause the score to be counted incorrectly.

@klapstoelpiloot klapstoelpiloot added the bug Something isn't working label Mar 17, 2023
@klapstoelpiloot klapstoelpiloot self-assigned this Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant